-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Maintenance/upgrade of httpx
library
#4171
⬆️ Maintenance/upgrade of httpx
library
#4171
Conversation
httpx
library
Codecov Report
@@ Coverage Diff @@
## master #4171 +/- ##
=========================================
- Coverage 85.9% 70.5% -15.4%
=========================================
Files 473 485 +12
Lines 24537 23944 -593
Branches 173 0 -173
=========================================
- Hits 21081 16895 -4186
- Misses 3407 7049 +3642
+ Partials 49 0 -49
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for both these upgrades
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
Here is a thought. I was wondering whether in this case it would have made sense to create a single PR to solve the vulnerability issue introduced by anyio
and httpx
. Note that the former is actually in the requirements because of the latter. Or in other words, from a dev perspective, we only know about httpx
In that case we could use something like
packages=httpx,anyio
for u in ${packages//,/ }
do
make reqs-all upgrade=$u &> reqs-$u.log
git commit -am "upgrades $u" --no-verify
done
Code Climate has analyzed commit 3d95444 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Unify httpx across the repository
autoscaling⬆️🧪
catalog⬆️🧪
datcore-adapter⬆️🧪
dynamic-sidecar⬆️
invitations⬆️🧪
autoscaling⬆️🧪
catalog⬆️🧪
datcore-adapter⬆️🧪
dynamic-sidecar⬆️
invitations⬆️🧪
catalog⬆️🧪
dynamic-sidecar⬆️
Legend:
Related issue/s
How to test
DevOps Checklist