-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ upgrading httpx for director-v2 #4160
⬆️ upgrading httpx for director-v2 #4160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you have verified that this upgrade is actually necessary, can you please follow up with a target upgrade of these two libraries on the entire repo?
Yes I will do so |
Thanks for this, and good luck. Tbh I looked at the changelog of the libraries and am doubtful that this will help. the gitlab issue chat you linked in the assoc. issue points towards this being a docker problem. |
Code Climate has analyzed commit 1c65415 and detected 0 issues on this pull request. View more on Code Climate. |
I'm doubtful myself it will help but it's an attempt at seeing how it behaves after the upgrade. I guess that after a few runs on master we will have a better idea of what is happening since the e2e triggers it |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #4160 +/- ##
=========================================
- Coverage 83.8% 67.2% -16.7%
=========================================
Files 955 399 -556
Lines 41366 20605 -20761
Branches 945 173 -772
=========================================
- Hits 34697 13858 -20839
- Misses 6465 6698 +233
+ Partials 204 49 -155
Flags with carried forward coverage won't be shown. Click here to find out more. |
What do these changes do?
Apparently
httpx
oranyio
(dependency) may have issues in resolving hostnames with docker. Trying to update to latest version to see if issue persists.Related issue/s
How to test
DevOps Checklist