Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ upgrading httpx for director-v2 #4160

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Apr 25, 2023

What do these changes do?

Apparently httpx or anyio (dependency) may have issues in resolving hostnames with docker. Trying to update to latest version to see if issue persists.

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK marked this pull request as ready for review April 25, 2023 08:10
@GitHK GitHK self-assigned this Apr 25, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you have verified that this upgrade is actually necessary, can you please follow up with a target upgrade of these two libraries on the entire repo?

@GitHK
Copy link
Contributor Author

GitHK commented Apr 25, 2023

Once you have verified that this upgrade is actually necessary, can you please follow up with a target upgrade of these two libraries on the entire repo?

Yes I will do so

@mrnicegyu11
Copy link
Member

Thanks for this, and good luck. Tbh I looked at the changelog of the libraries and am doubtful that this will help. the gitlab issue chat you linked in the assoc. issue points towards this being a docker problem.

@codeclimate
Copy link

codeclimate bot commented Apr 25, 2023

Code Climate has analyzed commit 1c65415 and detected 0 issues on this pull request.

View more on Code Climate.

@GitHK
Copy link
Contributor Author

GitHK commented Apr 25, 2023

Thanks for this, and good luck. Tbh I looked at the changelog of the libraries and am doubtful that this will help. the gitlab issue chat you linked in the assoc. issue points towards this being a docker problem.

I'm doubtful myself it will help but it's an attempt at seeing how it behaves after the upgrade.

I guess that after a few runs on master we will have a better idea of what is happening since the e2e triggers it

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #4160 (1c65415) into master (8b0dec7) will decrease coverage by 16.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4160      +/-   ##
=========================================
- Coverage    83.8%   67.2%   -16.7%     
=========================================
  Files         955     399     -556     
  Lines       41366   20605   -20761     
  Branches      945     173     -772     
=========================================
- Hits        34697   13858   -20839     
- Misses       6465    6698     +233     
+ Partials      204      49     -155     
Flag Coverage Δ
integrationtests 67.2% <ø> (+15.8%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 808 files with indirect coverage changes

@GitHK GitHK merged commit 5881834 into ITISFoundation:master Apr 25, 2023
@GitHK GitHK deleted the pr-osparc-httpx-anio-uprgrades branch April 25, 2023 09:15
@GitHK GitHK added the t:maintenance Some planned maintenance work label Apr 26, 2023
@GitHK GitHK added this to the Jelly Beans milestone Apr 26, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants