Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix edge case when cancelling observation #3878

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 14, 2023

What do these changes do?

  • ♻️ adds extra logs for the connection pool in the dynamic_sidecar_client
  • 🐛 fixes an edge case where dynamic sidecars scheduler would end up in a loop calling _apply_observation_cycle and mark_service_for_removal. This was introduced when 🐛 observation cycle cancellation #3771 was added

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #3878 (9b47d87) into master (b88565c) will decrease coverage by 12.6%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3878      +/-   ##
=========================================
- Coverage    85.0%   72.4%   -12.6%     
=========================================
  Files         933     383     -550     
  Lines       40015   19637   -20378     
  Branches      837     137     -700     
=========================================
- Hits        34042   14232   -19810     
+ Misses       5752    5356     -396     
+ Partials      221      49     -172     
Flag Coverage Δ
integrationtests 66.6% <100.0%> (-0.2%) ⬇️
unittests 86.2% <100.0%> (+4.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tor_v2/modules/dynamic_sidecar/api_client/_base.py 98.6% <ø> (ø)
...ector_v2/modules/dynamic_sidecar/scheduler/_abc.py 100.0% <ø> (ø)
...dules/dynamic_sidecar/scheduler/_core/_observer.py 92.4% <ø> (-3.8%) ⬇️
...ules/dynamic_sidecar/scheduler/_core/_scheduler.py 78.2% <100.0%> (+0.1%) ⬆️
...ctor_v2/modules/dynamic_sidecar/scheduler/_task.py 94.1% <100.0%> (ø)
...r/src/simcore_service_webserver/storage_schemas.py 0.0% <0.0%> (-100.0%) ⬇️
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) ⬇️
...es/web/server/src/simcore_service_webserver/log.py 0.0% <0.0%> (-94.8%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) ⬇️
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-76.0%) ⬇️
... and 696 more

@GitHK GitHK changed the title ♻️ Extra logs to figure out if connections are stalling 🐛 Fix edge case when cancelling observation Feb 14, 2023
@GitHK GitHK self-assigned this Feb 14, 2023
@GitHK GitHK added High Priority a totally crucial bug/feature to be fixed asap changelog:🐛bugfix labels Feb 14, 2023
@GitHK GitHK added this to the Resistance Is Futile milestone Feb 14, 2023
@GitHK GitHK marked this pull request as ready for review February 14, 2023 15:49
@codeclimate
Copy link

codeclimate bot commented Feb 15, 2023

Code Climate has analyzed commit 9b47d87 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK enabled auto-merge (squash) February 15, 2023 08:03
@GitHK GitHK merged commit c4d4a9e into ITISFoundation:master Feb 15, 2023
@GitHK GitHK deleted the pr-osparc-dv2-httpx-client-timeouts branch February 15, 2023 09:26
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-ops-environments that referenced this pull request Feb 15, 2023
mrnicegyu11 added a commit to ITISFoundation/osparc-ops-environments that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority a totally crucial bug/feature to be fixed asap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants