-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix edge case when cancelling observation #3878
🐛 Fix edge case when cancelling observation #3878
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3878 +/- ##
=========================================
- Coverage 85.0% 72.4% -12.6%
=========================================
Files 933 383 -550
Lines 40015 19637 -20378
Branches 837 137 -700
=========================================
- Hits 34042 14232 -19810
+ Misses 5752 5356 -396
+ Partials 221 49 -172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/director-v2/tests/unit/test_modules_dynamic_sidecar_observer.py
Outdated
Show resolved
Hide resolved
services/director-v2/tests/unit/test_modules_dynamic_sidecar_client_api_base.py
Show resolved
Hide resolved
Code Climate has analyzed commit 9b47d87 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
…Foundation/osparc-simcore#3878 (#104) Co-authored-by: Dustin Kaiser <[email protected]>
What do these changes do?
_apply_observation_cycle
andmark_service_for_removal
. This was introduced when 🐛 observation cycle cancellation #3771 was addedRelated issue/s
How to test
Checklist