-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 observation cycle cancellation #3771
🐛 observation cycle cancellation #3771
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3771 +/- ##
=========================================
- Coverage 84.7% 72.5% -12.2%
=========================================
Files 867 374 -493
Lines 37431 19064 -18367
Branches 791 135 -656
=========================================
- Hits 31718 13829 -17889
+ Misses 5502 5186 -316
+ Partials 211 49 -162
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! please check the comments
...tor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler.py
Show resolved
Hide resolved
...tor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler.py
Show resolved
Hide resolved
...tor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler.py
Outdated
Show resolved
Hide resolved
...tor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler.py
Outdated
Show resolved
Hide resolved
...tor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler.py
Outdated
Show resolved
Hide resolved
Code Climate has analyzed commit 5a30ea9 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Adding cancellation of observation cycle. Allows for resources to be freed and services to close faster.
NOTE: by design, the legacy dynamic sidecar scheduler, never supported this. The observation cycle will raise some unexpected errors when cancelled. 🔨🔨
NOTE: upcoming, new version of the scheduler, already comes with proper cancellation and will avoid all this mess.
Related issue/s
How to test
Checklist