Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 observation cycle cancellation #3771

Merged
merged 6 commits into from
Jan 18, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 17, 2023

What do these changes do?

Adding cancellation of observation cycle. Allows for resources to be freed and services to close faster.

NOTE: by design, the legacy dynamic sidecar scheduler, never supported this. The observation cycle will raise some unexpected errors when cancelled. 🔨🔨

NOTE: upcoming, new version of the scheduler, already comes with proper cancellation and will avoid all this mess.

Related issue/s

How to test

Checklist

@GitHK GitHK self-assigned this Jan 17, 2023
@GitHK GitHK added this to the Resistance Is Futile milestone Jan 17, 2023
@GitHK GitHK added a:director-v2 issue related with the director-v2 service changelog:🐛bugfix labels Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #3771 (5a30ea9) into master (f5407b2) will decrease coverage by 12.2%.
The diff coverage is 95.4%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3771      +/-   ##
=========================================
- Coverage    84.7%   72.5%   -12.2%     
=========================================
  Files         867     374     -493     
  Lines       37431   19064   -18367     
  Branches      791     135     -656     
=========================================
- Hits        31718   13829   -17889     
+ Misses       5502    5186     -316     
+ Partials      211      49     -162     
Flag Coverage Δ
integrationtests 66.8% <95.4%> (+0.1%) ⬆️
unittests 86.3% <54.5%> (+3.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ules/dynamic_sidecar/scheduler/_core/_scheduler.py 78.0% <95.4%> (+1.4%) ⬆️
...r/src/simcore_service_webserver/storage_schemas.py 0.0% <0.0%> (-100.0%) ⬇️
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) ⬇️
...es/web/server/src/simcore_service_webserver/log.py 0.0% <0.0%> (-94.8%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) ⬇️
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-76.0%) ⬇️
...rc/simcore_service_webserver/version_control_db.py 24.5% <0.0%> (-68.7%) ⬇️
...src/simcore_service_webserver/activity/handlers.py 29.3% <0.0%> (-63.8%) ⬇️
...ce_webserver/studies_dispatcher/_studies_access.py 22.7% <0.0%> (-63.7%) ⬇️
...ver/src/simcore_service_webserver/catalog_units.py 24.0% <0.0%> (-61.2%) ⬇️
... and 615 more

@GitHK GitHK marked this pull request as ready for review January 17, 2023 13:43
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! please check the comments

@GitHK GitHK enabled auto-merge (squash) January 17, 2023 15:16
@GitHK GitHK requested a review from pcrespov January 18, 2023 07:40
@codeclimate
Copy link

codeclimate bot commented Jan 18, 2023

Code Climate has analyzed commit 5a30ea9 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK merged commit 9dabedc into ITISFoundation:master Jan 18, 2023
@GitHK GitHK deleted the pr-osparc-pending-resources-issue branch January 18, 2023 08:22
@GitHK GitHK restored the pr-osparc-pending-resources-issue branch January 18, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic sidecar: A pending resource service never stops when going to dashboard
3 participants