Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeProgress in frontend #3786

Merged
merged 20 commits into from
Jan 24, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 23, 2023

What do these changes do?

This PR brings the frontend for #3773.

The node start-up sequence is as follows:
1 - CLUSTER_UP_SCALING
2 - SIDECAR_PULLING
3a - SERVICE_INPUTS_PULLING
3b - SERVICE_OUTPUTS_PULLING
3c - SERVICE_STATE_PULLING
4 - SERVICE_IMAGES_PULLING

All these steps have a progress bar that is shown when the frontend gets some step progress. Regarding the up-scaling, since there is no progress, when we are in this step a message saying This step can take up to 3 minutes is shown.

In the node loading page, below the node state, this is shown: (due to several issues, the messages for the animation were faked)
nodeProgress

Related issue/s

Show progress. Related to ITISFoundation/osparc-issues#765
closes #3788

How to test

Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:✨new-feature labels Jan 23, 2023
@odeimaiz odeimaiz added this to the Resistance Is Futile milestone Jan 23, 2023
@odeimaiz odeimaiz self-assigned this Jan 23, 2023
@odeimaiz odeimaiz changed the title WIP ✨ progressStatus in frontend WIP ✨ nodeProgress in frontend Jan 24, 2023
@odeimaiz odeimaiz marked this pull request as ready for review January 24, 2023 10:45
@odeimaiz odeimaiz changed the title WIP ✨ nodeProgress in frontend nodeProgress in frontend Jan 24, 2023
@mrnicegyu11 mrnicegyu11 removed their request for review January 24, 2023 10:46
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeclimate
Copy link

codeclimate bot commented Jan 24, 2023

Code Climate has analyzed commit fdbb4f8 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz enabled auto-merge (squash) January 24, 2023 11:26
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

You might consider not showing the old messages (the ones that shows up directly below the service thumbnail) or showing a generic one e.g. "Loading you project/study".

@odeimaiz
Copy link
Member Author

odeimaiz commented Jan 24, 2023

You might consider not showing the old messages (the ones that shows up directly below the service thumbnail) or showing a generic one e.g. "Loading you project/study".

I think they are not old, just a kind of a subtask progress. @sanderegg ?

@sanderegg
Copy link
Member

You might consider not showing the old messages (the ones that shows up directly below the service thumbnail) or showing a generic one e.g. "Loading you project/study".

I think they are not old, just a kind of a subtask progress. @sanderegg ?

So I am trying to differentiate service state information from task progress.
a service is pending, pulling, starting, stopping this is the service state
a service's outputs are pushing/pulling or the service's states are pushing/pulling with a progress.

Of course this is a work in progress and we can discuss whether we should at some point replace one with another.

@odeimaiz odeimaiz merged commit 2bd6848 into ITISFoundation:master Jan 24, 2023
@odeimaiz odeimaiz deleted the feature/progress-messages branch August 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to dashboard when simulations are still running in an open study
4 participants