Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enhancement/improve progress messages #3773

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 17, 2023

What do these changes do?

Brings more progress messages to the frontend:

  • cluster up-scaling
  • sidecar image pulling (might come later)
  • state push/pull
  • inputs pull
  • outputs pull
  • service image pulling
  • comp. service running

This PR enables a new exchange in RabbitMQ for progress information.
This progress are forwarded to the webclient with the nodeProgress event that contains:

{
  "user_id": int,
  "project_id": uuid,
  "node_id": uuid,
  "progress_type": str,
  "progress": 0-1.0
}

progress type can be of the following:

"COMPUTATION_RUNNING"

"CLUSTER_UP_SCALING"
"SIDECAR_PULLING"
"SERVICE_INPUTS_PULLING"
"SERVICE_OUTPUTS_PULLING"
"SERVICE_STATE_PULLING"
"SERVICE_IMAGES_PULLING"

"SERVICE_STATE_PUSHING"
"SERVICE_OUTPUTS_PUSHING"

NOTE:
for the SERVICE_IMAGES_PULLING as well as for SIDECAR_PULLING it is not possible to know the layer sizes a priori. therefore the progress might "go back in time"

Bonus:

  • log messages now contain a log level based on python logging system as an int
  • fix regex for docker generic tags such as envoyproxy/envoy:latest

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #3773 (177b882) into master (cca02d0) will increase coverage by 1.3%.
The diff coverage is 68.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3773     +/-   ##
========================================
+ Coverage    84.8%   86.2%   +1.3%     
========================================
  Files         915     759    -156     
  Lines       38866   34795   -4071     
  Branches      791     387    -404     
========================================
- Hits        32978   29994   -2984     
+ Misses       5678    4696    -982     
+ Partials      210     105    -105     
Flag Coverage Δ
integrationtests 66.8% <76.9%> (-0.1%) ⬇️
unittests 83.0% <65.7%> (+1.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/models-library/src/models_library/basic_regex.py 100.0% <ø> (ø)
...rector_v2/modules/comp_scheduler/dask_scheduler.py 89.4% <ø> (ø)
...e_service_director_v2/modules/projects_networks.py 75.2% <ø> (ø)
...c/simcore_service_dynamic_sidecar/core/rabbitmq.py 92.0% <40.0%> (-5.8%) ⬇️
...imcore_service_autoscaling/dynamic_scaling_core.py 87.1% <55.0%> (-3.3%) ⬇️
...mcore_service_dynamic_sidecar/core/docker_utils.py 75.0% <55.1%> (-25.0%) ⬇️
...src/simcore_sdk/node_ports_common/file_io_utils.py 88.7% <55.5%> (+0.3%) ⬆️
...vice_dynamic_sidecar/modules/long_running_tasks.py 92.1% <57.1%> (-1.8%) ⬇️
...simcore_service_webserver/computation_subscribe.py 95.3% <75.0%> (-3.0%) ⬇️
.../src/simcore_service_autoscaling/utils/rabbitmq.py 96.7% <83.3%> (-3.3%) ⬇️
... and 170 more

@sanderegg sanderegg force-pushed the enhancement/improve_progress_messages branch 2 times, most recently from 6c91af5 to bd041d9 Compare January 19, 2023 21:43
@sanderegg sanderegg force-pushed the enhancement/improve_progress_messages branch from 4c6c4d7 to 25d7cb1 Compare January 20, 2023 14:19
@sanderegg sanderegg marked this pull request as ready for review January 20, 2023 17:20
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! some comments

@codeclimate
Copy link

codeclimate bot commented Jan 23, 2023

Code Climate has analyzed commit 177b882 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 99db5b7 into ITISFoundation:master Jan 23, 2023
@sanderegg sanderegg deleted the enhancement/improve_progress_messages branch January 23, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants