-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enhancement/improve progress messages #3773
✨ Enhancement/improve progress messages #3773
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3773 +/- ##
========================================
+ Coverage 84.8% 86.2% +1.3%
========================================
Files 915 759 -156
Lines 38866 34795 -4071
Branches 791 387 -404
========================================
- Hits 32978 29994 -2984
+ Misses 5678 4696 -982
+ Partials 210 105 -105
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6c91af5
to
bd041d9
Compare
4c6c4d7
to
25d7cb1
Compare
packages/simcore-sdk/src/simcore_sdk/node_ports_common/file_io_utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! some comments
services/web/server/src/simcore_service_webserver/computation_subscribe.py
Outdated
Show resolved
Hide resolved
Code Climate has analyzed commit 177b882 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Brings more progress messages to the frontend:
sidecar image pulling(might come later)This PR enables a new exchange in RabbitMQ for progress information.
This progress are forwarded to the webclient with the
nodeProgress
event that contains:progress type can be of the following:
NOTE:
for the SERVICE_IMAGES_PULLING as well as for SIDECAR_PULLING it is not possible to know the layer sizes a priori. therefore the progress might "go back in time"
Bonus:
Related issue/s
How to test
Checklist