Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "⬆️ Maintenance: Upgrade python-socketio + flakyness (… #3631

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 1, 2022

#3622)" (#3630)"

This reverts commit 719bf1c.

https://python-socketio.readthedocs.io/en/latest/intro.html
image

Bonus: fixes #3574

What do these changes do?

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #3631 (cbc8ce8) into master (0cea2a5) will decrease coverage by 0.2%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3631      +/-   ##
=========================================
- Coverage    84.2%   84.0%    -0.3%     
=========================================
  Files         876     355     -521     
  Lines       37053   18138   -18915     
  Branches      784     135     -649     
=========================================
- Hits        31223   15244   -15979     
+ Misses       5623    2845    -2778     
+ Partials      207      49     -158     
Flag Coverage Δ
integrationtests 67.4% <100.0%> (+<0.1%) ⬆️
unittests 83.0% <100.0%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/src/simcore_service_webserver/socketio/server.py 100.0% <100.0%> (ø)
...-v2/src/simcore_service_director_v2/cli/_client.py 0.0% <0.0%> (-100.0%) ⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...service_director_v2/cli/_close_and_save_service.py 0.0% <0.0%> (-100.0%) ⬇️
...or-v2/src/simcore_service_director_v2/cli/_core.py 0.0% <0.0%> (-87.5%) ⬇️
...ce_director_v2/modules/db/repositories/clusters.py 23.0% <0.0%> (-71.7%) ⬇️
...k/src/simcore_sdk/node_ports_v2/port_validation.py 47.9% <0.0%> (-48.0%) ⬇️
...ervice_director_v2/api/routes/dynamic_scheduler.py 50.0% <0.0%> (-47.1%) ⬇️
...simcore_service_director_v2/api/routes/clusters.py 57.6% <0.0%> (-41.1%) ⬇️
...ore_service_director_v2/utils/dask_client_utils.py 46.0% <0.0%> (-40.9%) ⬇️
... and 585 more

@sanderegg sanderegg marked this pull request as ready for review December 6, 2022 15:24
@sanderegg sanderegg requested a review from mguidon December 6, 2022 15:24
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 You could have just called this an upgrade.

@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 1f4aa36 into ITISFoundation:master Dec 8, 2022
@sanderegg sanderegg deleted the maintenance/update_python_socketio2 branch December 8, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests/integration/02/test_rabbit.py::test_publish_about_users_project
4 participants