⬆️ Maintenance: Upgrade python-socketio + flakyness #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3622 +/- ##
======================================
Coverage 83.3% 83.3%
======================================
Files 868 868
Lines 36555 36555
Branches 782 782
======================================
Hits 30486 30486
Misses 5862 5862
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more. |
sanderegg
force-pushed
the
maintenance/socket_io_update_and_flaky
branch
from
c938a04 to
aa76184
Compare
sanderegg
force-pushed
the
maintenance/socket_io_update_and_flaky
branch
from
aa76184 to
5642d3e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
sanderegg
added a commit
to sanderegg/osparc-simcore
that referenced
this pull request
Dec 1, 2022
…dation#3622)" This reverts commit db03a28.
sanderegg
added a commit
that referenced
this pull request
Dec 1, 2022
sanderegg
added a commit
to sanderegg/osparc-simcore
that referenced
this pull request
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Highlights on updated libraries (only updated libraries are included)
Legend:
This PR brings a big upgrade in python-socketio library.
Also aims at reducing the flakyness in the test_rabbit.py which was probably due to some lag in the transmission over websocket in the CI runners.
Related issue/s
as discussed here: miguelgrinberg/python-socketio#1092
closing the python-socketio AsyncServer needs some ad-hoc removal.
How to test
Checklist