-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Is686/apiserver api 0.4.2
: studies ports
#3623
✨ Is686/apiserver api 0.4.2
: studies ports
#3623
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3623 +/- ##
========================================
+ Coverage 78.5% 85.7% +7.1%
========================================
Files 788 515 -273
Lines 32577 24686 -7891
Branches 782 411 -371
========================================
- Hits 25598 21163 -4435
+ Misses 6772 3400 -3372
+ Partials 207 123 -84
Flags with carried forward coverage won't be shown. Click here to find out more.
|
890a442
to
7fa3a48
Compare
0.4.2
: studies ports
0.4.2
: studies ports0.4.2
: studies ports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good but I am confused with the NodeID type of the study port.
packages/pytest-simcore/src/pytest_simcore/helpers/faker_webserver.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/studies.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/studies.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/studies.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/studies.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, all clear. just the format name is confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice, have some questions below.
services/api-server/src/simcore_service_api_server/api/routes/studies.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_ports_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_ports_handlers.py
Outdated
Show resolved
Hide resolved
0b23f85
to
a5bf127
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Exposes ports of a study in the public-api.
New collection
studies
: roughly equivalent to aproject
.list_study_ports
:GET studies/{study_id}/ports
->list[StudyPort]
0.4.2
as a dev-feature (only available withAPI_SERVER_DEV_FEATURES_ENABLED=1
)0.5.0
Related issue/s
0.12
: project ports metadata #3621How to test
make devenv source .venv/bin/activate cd services/api-server make install-dev pytest -vv tests/**/test*studies*.py```
Checklist
make version-*
make openapi.json
cd packages/postgres-database
,make setup-commit
,sc-pg review -m "my changes"