-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 bugfix: Optional slideshow->instructions #3593
Merged
odeimaiz
merged 3 commits into
ITISFoundation:master
from
odeimaiz:fix/optional-instructions
Nov 22, 2022
Merged
🐛 bugfix: Optional slideshow->instructions #3593
odeimaiz
merged 3 commits into
ITISFoundation:master
from
odeimaiz:fix/optional-instructions
Nov 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3593 +/- ##
========================================
+ Coverage 83.5% 84.7% +1.1%
========================================
Files 861 709 -152
Lines 36132 32124 -4008
Branches 779 381 -398
========================================
- Hits 30200 27230 -2970
+ Misses 5727 4791 -936
+ Partials 205 103 -102
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
approved these changes
Nov 21, 2022
sanderegg
approved these changes
Nov 21, 2022
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
9 tasks
GitHK
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Make
Instructions
from theSlideshow
optional. Technically, a backend bug.