Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bugfix: Optional slideshow->instructions #3593

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

odeimaiz
Copy link
Member

What do these changes do?

Make Instructions from the Slideshow optional. Technically, a backend bug.

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #3593 (fbde744) into master (036a8c6) will increase coverage by 1.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3593     +/-   ##
========================================
+ Coverage    83.5%   84.7%   +1.1%     
========================================
  Files         861     709    -152     
  Lines       36132   32124   -4008     
  Branches      779     381    -398     
========================================
- Hits        30200   27230   -2970     
+ Misses       5727    4791    -936     
+ Partials      205     103    -102     
Flag Coverage Δ
integrationtests 65.6% <ø> (-1.7%) ⬇️
unittests 81.9% <100.0%> (+1.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/models-library/src/models_library/projects_ui.py 100.0% <100.0%> (ø)
...simcore_service_webserver/computation_subscribe.py 35.5% <0.0%> (-62.8%) ⬇️
.../simcore_service_webserver/computation_settings.py 55.5% <0.0%> (-44.5%) ⬇️
...erver/src/simcore_service_webserver/computation.py 75.0% <0.0%> (-25.0%) ⬇️
...service_webserver/projects/projects_nodes_utils.py 80.9% <0.0%> (-14.3%) ⬇️
...simcore_service_webserver/projects/projects_api.py 81.1% <0.0%> (-11.9%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 75.5% <0.0%> (-6.4%) ⬇️
...storage/src/simcore_service_storage/dsm_cleaner.py 94.5% <0.0%> (-5.5%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/_utils.py 92.0% <0.0%> (-2.0%) ⬇️
...mcore_service_webserver/garbage_collector_utils.py 85.8% <0.0%> (-1.3%) ⬇️
... and 155 more

@odeimaiz odeimaiz self-assigned this Nov 22, 2022
@odeimaiz odeimaiz added this to the Athena milestone Nov 22, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit e9d1386 into ITISFoundation:master Nov 22, 2022
pcrespov pushed a commit that referenced this pull request Nov 23, 2022
@odeimaiz odeimaiz added a:api framework api, data schemas, changelog:🐛bugfix labels Nov 26, 2022
@odeimaiz odeimaiz deleted the fix/optional-instructions branch August 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:api framework api, data schemas,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants