Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Group Templates by Tag #3587

Merged
merged 109 commits into from
Nov 29, 2022
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 18, 2022

What do these changes do?

In the sim4life-lite product, the Templates (aka Tutorials) need to be grouped by Tag so that users don't get a 40 items flat list.

To achieve this, we will take advantage of the recently implemented tags-for-groups feature. The idea is to tag the publicly available templates with tags that are also available to Everyone and use them for grouping the Tutorials.

If a tutorial has multiple tags, it will be present in multiple groups. On the other hand, if it has no tags, it will fall in the "No Group" group.

Main changes:

  • New container SlideBar based implemented. The container works similar to a carousel with partially transparent buttons on both sides.
  • All Sorting, View and Grouping buttons are now on the right side of the secondary bar. The rest of the buttons that were part of the secondary bar (Select studies, Delete studies) were moved to the left side.
  • sim4life-lite product will list the Tutorials grouped by default
  • Templates are all fetched before displaying them

The grouping can be extended to more types like Last changed (this week, last month, last year), Shared with (everyone, organizations, private)... this can be implemented in the next iterations

Tutorials grouped:
Groping

Related issue/s

Templates/Tutorials grouping: ITISFoundation/osparc-issues#765

How to test

Checklist

@odeimaiz odeimaiz added this to the Athena milestone Nov 18, 2022
@odeimaiz odeimaiz self-assigned this Nov 18, 2022
@odeimaiz odeimaiz changed the title ✨WIP: Group Studies/Templates by tag ✨WIP: Group Templates by tag Nov 21, 2022
@odeimaiz odeimaiz changed the title ✨WIP: Group Templates by tag ✨Group Templates by Tag Nov 28, 2022
@mrnicegyu11
Copy link
Member

supernice, thx

@mrnicegyu11 mrnicegyu11 removed their request for review November 28, 2022 16:36
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 looks great!

@mguidon mguidon self-requested a review November 29, 2022 13:39
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magnifico!

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real nice!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@odeimaiz odeimaiz enabled auto-merge (squash) November 29, 2022 14:39
@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz merged commit 5d3fdaa into ITISFoundation:master Nov 29, 2022
@odeimaiz odeimaiz deleted the feature/group-tags branch August 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants