Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add local_lib mvn repo and primefaces themes, pin base image to Ubuntu 22 #10721

Closed
wants to merge 3 commits into from

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jul 24, 2024

What this PR does / why we need it:

We are getting build errors.

Which issue(s) this PR closes:

Special notes for your reviewer:

The Primefaces error gets triggered first but there is a second error having to do with containers (#10722) that I'm fixing in this PR as well.

I tried added just "all-themes" but "themes-project" seems to be required as well.

We used to have a local_lib repo but we removed it in this PR:

Suggestions on how to test this:

  • Make sure you can build.
  • Make sure the UI looks ok? I'm not sure how the themes are used.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

I hope not.

Is there a release notes update needed for this change?:

No.

Additional documentation:

None.

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Quick and dirty, but it will fix Jenkins for the time being. And we can always remove local_lib again if PrimeFaces get their act straight.

@coveralls
Copy link

coveralls commented Jul 24, 2024

Coverage Status

coverage: 20.657% (+0.006%) from 20.651%
when pulling f80ebce on 10718-pf-themes
into d33e249 on develop.

This comment has been minimized.

@stevenwinship stevenwinship self-assigned this Jul 24, 2024
@pdurbin
Copy link
Member Author

pdurbin commented Jul 24, 2024

There's active discussion of what happened to the Primefaces maven repo at https://github.com/orgs/primefaces/discussions/2382

@stevenwinship
Copy link
Contributor

stevenwinship commented Jul 24, 2024

I re-ran "Base Container Image / Build image" a couple of times but it still fails. @pdurbin could you take a look. I won't merge this without the tests passing. Locally I could build and run the docker version with no issues.

@pdurbin
Copy link
Member Author

pdurbin commented Jul 24, 2024

@stevenwinship weird. Since it's a Docker error I kicked off a thread in #containers about it. It's a new one on me! Very strange. 🤔

I looked at other PRs and my guess is that they would start seeing the Docker error after they get past the Primefaces error. But that's just a guess. 🤷

@pdurbin
Copy link
Member Author

pdurbin commented Jul 24, 2024

There's an offer from Primefaces to put artifacts on Maven Central so I explained what we need: https://github.com/orgs/primefaces/discussions/2382#discussioncomment-10141453

This would be better than a local_lib directory.

@pdurbin pdurbin changed the title add local_lib mvn repo and primefaces themes add local_lib mvn repo and primefaces themes, pin base image to Ubuntu 22 Jul 24, 2024
@pdurbin
Copy link
Member Author

pdurbin commented Jul 24, 2024

@stevenwinship the "base container image" is passing now that I pushed some fixes for a second issue:

We might want to see if @poikilotherm is ok with those container-related changes before we merge. I have a thread going in Zulip about it.

This comment has been minimized.

1 similar comment
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10718-pf-themes
ghcr.io/gdcc/configbaker:10718-pf-themes

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@pdurbin
Copy link
Member Author

pdurbin commented Jul 25, 2024

I'm closing this PR for two reasons:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants