-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add local_lib mvn repo and primefaces themes, pin base image to Ubuntu 22 #10721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Quick and dirty, but it will fix Jenkins for the time being. And we can always remove local_lib again if PrimeFaces get their act straight.
This comment has been minimized.
This comment has been minimized.
There's active discussion of what happened to the Primefaces maven repo at https://github.com/orgs/primefaces/discussions/2382 |
I re-ran "Base Container Image / Build image" a couple of times but it still fails. @pdurbin could you take a look. I won't merge this without the tests passing. Locally I could build and run the docker version with no issues. |
@stevenwinship weird. Since it's a Docker error I kicked off a thread in #containers about it. It's a new one on me! Very strange. 🤔 I looked at other PRs and my guess is that they would start seeing the Docker error after they get past the Primefaces error. But that's just a guess. 🤷 |
There's an offer from Primefaces to put artifacts on Maven Central so I explained what we need: https://github.com/orgs/primefaces/discussions/2382#discussioncomment-10141453 This would be better than a local_lib directory. |
@stevenwinship the "base container image" is passing now that I pushed some fixes for a second issue: We might want to see if @poikilotherm is ok with those container-related changes before we merge. I have a thread going in Zulip about it. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
I'm closing this PR for two reasons:
|
What this PR does / why we need it:
We are getting build errors.
Which issue(s) this PR closes:
Special notes for your reviewer:
The Primefaces error gets triggered first but there is a second error having to do with containers (#10722) that I'm fixing in this PR as well.
I tried added just "all-themes" but "themes-project" seems to be required as well.
We used to have a local_lib repo but we removed it in this PR:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
I hope not.
Is there a release notes update needed for this change?:
No.
Additional documentation:
None.