Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change _CT_DATAVERSE_SITEURL to DATAVERSE_SITEURL #10756

Closed
pdurbin opened this issue Aug 7, 2024 · 0 comments · Fixed by #10792
Closed

Change _CT_DATAVERSE_SITEURL to DATAVERSE_SITEURL #10756

pdurbin opened this issue Aug 7, 2024 · 0 comments · Fixed by #10792
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. Feature: Container Guide Size: 3 A percentage of a sprint. 2.1 hours.
Milestone

Comments

@pdurbin
Copy link
Member

pdurbin commented Aug 7, 2024

This is where _CT_DATAVERSE_SITEURL appears, currently:

docker/compose/demo/compose.yml
12: _CT_DATAVERSE_SITEURL: "https://demo.example.org"

doc/sphinx-guides/source/container/running/demo.rst
127:Please note that for a few environment variables (the ones that start with %ct in :download:microprofile-config.properties <../../../../../src/main/resources/META-INF/microprofile-config.properties>), you have to prepend _CT_ to make, for example, _CT_DATAVERSE_SITEURL. We are working on a fix for this in #10285.

It should be changed to just DATAVERSE_SITEURL, after testing it, of course.

For more context on why CT was needed, see this issue:

See also:

@pdurbin pdurbin converted this from a draft issue Aug 7, 2024
@pdurbin pdurbin added Component: Containers Anything related to cloudy Dataverse, shipped in containers. Feature: Container Guide labels Aug 7, 2024
@pdurbin pdurbin changed the title Remove _CT_DATAVERSE_SITEURL from guides (not needed), see #10285 Change _CT_DATAVERSE_SITEURL to DATAVERSE_SITEURL Aug 7, 2024
@pdurbin pdurbin added the Size: 3 A percentage of a sprint. 2.1 hours. label Aug 7, 2024
pdurbin added a commit that referenced this issue Aug 22, 2024
The _CT_ version is not needed now that we have upgraded to
Payara 6.2024.6 in #10495 which included this fix:
payara/Payara#6550
@pdurbin pdurbin added this to the 6.4 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. Feature: Container Guide Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant