Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In containers, can't set DATAVERSE_SITEURL using documented methods #10285

Closed
pdurbin opened this issue Jan 30, 2024 · 0 comments · Fixed by #10495
Closed

In containers, can't set DATAVERSE_SITEURL using documented methods #10285

pdurbin opened this issue Jan 30, 2024 · 0 comments · Fixed by #10495
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. Size: 3 A percentage of a sprint. 2.1 hours.
Milestone

Comments

@pdurbin
Copy link
Member

pdurbin commented Jan 30, 2024

For context, I'm working on the following pull request...

... trying to help push our containers from "dev mode" to "demo mode".

A very important setting for a demo is dataverse.siteUrl but I can't set it using a Docker compose.yml using any of the methods documented at https://guides.dataverse.org/en/6.1/installation/config.html#dataverse-siteurl

These don't work:

    environment:
      DATAVERSE_SITEURL: "https://demo.dataverse.org"
    environment:
      JVM_ARGS: -Ddataverse.siteUrl=https://demo.dataverse.org

@poikilotherm explained a workaround that does work:

      _CT_DATAVERSE_SITEURL: "https://demo.dataverse.org"

That is to say, you have to prepend _CT_, probably because it's the name of the profile we use.

This affects other settings as well, such as DATAVERSE_SOLR_HOST.

My understanding of the problem is that we explicitly set the siteUrl here...

https://github.com/IQSS/dataverse/blob/v6.1/src/main/resources/META-INF/microprofile-config.properties#L9

... as %ct.dataverse.siteUrl=http://${dataverse.fqdn}:8080 and we can't override it the way we expect.

For now, for the demo/eval tutorial, I'll simply document the _CT_ workaround, but I'm opening this issue to resolve the underlying problem.

The following PR by @poikilotherm was already merged...

... and Payara 6.2023.12 and newer might include a fix. We should test and see.

There's additional discussion in Zulip: https://dataverse.zulipchat.com/#narrow/stream/375812-containers/topic/MPC.20profile.20problem/near/358512660

I'm giving this a size or 3 for:

  • build base image with latest Payara
  • test if the workaround is no longer needed
  • if not needed, talk more with the team about upgrading Payara
  • if still needed, report to Payara that the bug hasn't been fixed yet
@pdurbin pdurbin added Component: Containers Anything related to cloudy Dataverse, shipped in containers. Size: 3 A percentage of a sprint. 2.1 hours. labels Jan 30, 2024
@pdurbin pdurbin added this to the 6.3 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant