-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
197 compare dataset versions #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments here mostly about formatting. Please check them~
src/datasets/infra/repositories/transformers/DatasetVersionDiffPayload.ts
Outdated
Show resolved
Hide resolved
src/datasets/infra/repositories/transformers/datasetVersionDiffTransformers.ts
Outdated
Show resolved
Hide resolved
thanks @ChengShi-1 ! I addressed your comments and removed the waiting tag, since the Dataverse API change was merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thanks! Approve. (I found one piece of comment didn't get remove so I just did it with a new commit.)
Merging PR - tests are passing. |
What this PR does / why we need it:
Creates use case for comparing Dataset versions. For information on the API endpoint, see IQSS/dataverse#10945
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Review the code changes and run the tests
Is there a release notes update needed for this change?:
Additional documentation: