Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

197 compare dataset versions #220

Merged
merged 11 commits into from
Nov 26, 2024
Merged

Conversation

ekraffmiller
Copy link
Contributor

@ekraffmiller ekraffmiller commented Nov 14, 2024

What this PR does / why we need it:

Creates use case for comparing Dataset versions. For information on the API endpoint, see IQSS/dataverse#10945

Which issue(s) this PR closes:

Related Dataverse PRs:

  • Depends on #10945 (merged)

Special notes for your reviewer:

Suggestions on how to test this:

Review the code changes and run the tests

Is there a release notes update needed for this change?:

Additional documentation:

@ekraffmiller ekraffmiller added FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) SPA.Q4.10 Resolve TODOs and tech debt Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset View Page labels Nov 14, 2024
@g-saracca g-saracca added the GREI Re-arch GREI re-architecture-related label Nov 14, 2024
@ekraffmiller ekraffmiller marked this pull request as draft November 14, 2024 20:08
@ekraffmiller ekraffmiller marked this pull request as ready for review November 15, 2024 16:34
@ChengShi-1 ChengShi-1 self-requested a review November 20, 2024 15:50
@cmbz cmbz added the FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) label Nov 21, 2024
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments here mostly about formatting. Please check them~

@ekraffmiller
Copy link
Contributor Author

thanks @ChengShi-1 ! I addressed your comments and removed the waiting tag, since the Dataverse API change was merged

Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks! Approve. (I found one piece of comment didn't get remove so I just did it with a new commit.)

@ofahimIQSS
Copy link
Contributor

Merging PR - tests are passing.

@ofahimIQSS ofahimIQSS merged commit f21affc into develop Nov 26, 2024
5 checks passed
@ofahimIQSS ofahimIQSS deleted the 197-compare-dataset-versions branch November 26, 2024 17:56
@ofahimIQSS ofahimIQSS removed their assignment Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset View Page SPA.Q4.10 Resolve TODOs and tech debt
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Create use case for comparing Dataset versions
5 participants