Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile for OpenRAM/OpenLane. OpenRAM make rule added #228

Merged
merged 4 commits into from
Nov 3, 2021
Merged

Makefile for OpenRAM/OpenLane. OpenRAM make rule added #228

merged 4 commits into from
Nov 3, 2021

Conversation

microSharjeel
Copy link
Contributor

This rule in the Makefile will run the OpenRAM (provided OpenRAM and all its dependencies are installed on that machine).
Next step is to integrate it with asic.mk
We can discuss this
regards
Sharjeel

@@ -1 +1,7 @@
#Makefile for OpenLane and OpenRAM started on 2/11/21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this file and call it simply Makefile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok Sir

@@ -1 +1,7 @@
#Makefile for OpenLane and OpenRAM started on 2/11/21
SRAM:
python3 $(OPENRAM_HOME)/openram.py $(OPENRAM_CONFIG)/myconfig.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPENRAM_HOME should be OPENRAM_COMPILER
OPENRAM_CONFIG should be OPENRAM_HOME

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPENRAM_HOME is py file for OpenRAM
and OPENRAM_CONFIG has the configuration that user can modify to change all the params of the SRAM
I will modify them now

@@ -242,6 +242,7 @@ git clone https://github.com/VLSIDA/OpenRAM
```bash
export OPENRAM_HOME="$HOME/openram/compiler"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind the suggested name changes

you can't assume openram is installed in $HOME

Instead ask the user to

export OPENRAM_HOME=path/to/openram

so this can be any directory the user may like

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I got it sir I am going to change it now

SRAM:
python3 $(OPENRAM_HOME)/openram.py $(OPENRAM_CONFIG)/myconfig.py

.PHONY clean:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware of this syntax. Are you sure?

I use
.PHONY: clean

let's start putting the phony list before the targets

there is no target clean, so pls create it after you declare it as phony

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir I am making all these changes now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly check now

hardware/asic/skywater/Makefile Outdated Show resolved Hide resolved
@jjts jjts merged commit 7a801b2 into IObundle:asic Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants