-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile for OpenRAM/OpenLane. OpenRAM make rule added #228
Conversation
@@ -1 +1,7 @@ | |||
#Makefile for OpenLane and OpenRAM started on 2/11/21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this file and call it simply Makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok Sir
@@ -1 +1,7 @@ | |||
#Makefile for OpenLane and OpenRAM started on 2/11/21 | |||
SRAM: | |||
python3 $(OPENRAM_HOME)/openram.py $(OPENRAM_CONFIG)/myconfig.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OPENRAM_HOME should be OPENRAM_COMPILER
OPENRAM_CONFIG should be OPENRAM_HOME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OPENRAM_HOME is py file for OpenRAM
and OPENRAM_CONFIG has the configuration that user can modify to change all the params of the SRAM
I will modify them now
hardware/asic/README.md
Outdated
@@ -242,6 +242,7 @@ git clone https://github.com/VLSIDA/OpenRAM | |||
```bash | |||
export OPENRAM_HOME="$HOME/openram/compiler" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind the suggested name changes
you can't assume openram is installed in $HOME
Instead ask the user to
export OPENRAM_HOME=path/to/openram
so this can be any directory the user may like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I got it sir I am going to change it now
hardware/asic/skywater/Makefile
Outdated
SRAM: | ||
python3 $(OPENRAM_HOME)/openram.py $(OPENRAM_CONFIG)/myconfig.py | ||
|
||
.PHONY clean: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not aware of this syntax. Are you sure?
I use
.PHONY: clean
let's start putting the phony list before the targets
there is no target clean, so pls create it after you declare it as phony
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sir I am making all these changes now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly check now
This rule in the Makefile will run the OpenRAM (provided OpenRAM and all its dependencies are installed on that machine).
Next step is to integrate it with asic.mk
We can discuss this
regards
Sharjeel