fix: fix Maven source and test source directory resolving #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Would you add the corresponding test case? Thanks! |
41 tasks
|
Not sure why the test is failing, it works locally |
|
Thanks a lot for the test case + the fix. I guess the CI environment is slightly different or a file is missing? |
…om.xml hierarchy to find the nearest ancestor that declares the source directory. Also added interpolating (project|pom|'').basedir
…e not linked via pom.xml to the model
Strum355
force-pushed
the
better-pom
branch
3 times, most recently
from
76db1d3 to
be9816f
Compare
|
@monperrus fixed the test case, the folder was missing because there were no files 👍 |
monperrus
reviewed
Sep 9, 2020
| SpoonPom childModel = pomModel.getModules().get(0); | ||
| //contract: source directory is derived from parent pom.xml if not declared in the current | ||
| // (childModel) SpoonPom | ||
| assertEquals(expected, childModel.getSourceDirectories().get(0).getAbsolutePath(), expected); |
There was a problem hiding this comment.
expected should be the second argument, not the last
you can remove the first one, the message, not relevant here
There was a problem hiding this comment.
Fixed according to the hover definition 👍
monperrus
changed the title
|
Thanks a lot @Strum355 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By climbing the pom.xml hierarchy to find the nearest ancestor that declares the source directory rather than immediately falling back to src/(main|test)/java if not declared in this immediate pom.
Also added interpolating (project|pom|'').basedir which is not uncommonly found in projects.