You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Spoons handling of finding source directories defined in pom.xml needs to be improved. Two issues found:
If a module/pom file doesn't specify <sourceDirectory> and/or <testSourceDirectory>, it falls back to a default for whichever were missing (src/main/java and src/test/java respectively), even if they would be defined in an ancestor up the pom hierarchy. This issue at the time of writing has been addressed locally, PR incoming soon:tm:
Ref: POM inheritance
Spoon doesn't interpolate ${project.basedir}, which was encounted in some repos. PR mentioned above will also address this.
Theory: in multi-maven-project scenarios (>1 pom.xml file in a repo), in root pom files that don't act as aggregators (aka don't define a <module> block), maven projects that aren't the root project would be missed, and therefore not indexed. This could be addressed in lsif-java itself by comparing the discovered-by-Spoon projects and comparing it to the discovered-by-filesystem-tree-walking pom.xml files/projects, and adding the missing projects to the Spoon model's input resources.
Ref: POM aggregation
The text was updated successfully, but these errors were encountered:
This is a multi (at least 2) tiered issue.
<sourceDirectory>
and/or<testSourceDirectory>
, it falls back to a default for whichever were missing (src/main/java
andsrc/test/java
respectively), even if they would be defined in an ancestor up the pom hierarchy. This issue at the time of writing has been addressed locally, PR incoming soon:tm:Ref: POM inheritance
${project.basedir}
, which was encounted in some repos. PR mentioned above will also address this.<module>
block), maven projects that aren't the root project would be missed, and therefore not indexed. This could be addressed in lsif-java itself by comparing the discovered-by-Spoon projects and comparing it to the discovered-by-filesystem-tree-walking pom.xml files/projects, and adding the missing projects to the Spoon model's input resources.Ref: POM aggregation
The text was updated successfully, but these errors were encountered: