Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential for numerous files to be missed on indexing #35

Closed
Strum355 opened this issue Sep 2, 2020 · 3 comments
Closed

Potential for numerous files to be missed on indexing #35

Strum355 opened this issue Sep 2, 2020 · 3 comments

Comments

@Strum355
Copy link
Contributor

Strum355 commented Sep 2, 2020

This is a multi (at least 2) tiered issue.

  1. Spoons handling of finding source directories defined in pom.xml needs to be improved. Two issues found:
    1. If a module/pom file doesn't specify <sourceDirectory> and/or <testSourceDirectory>, it falls back to a default for whichever were missing (src/main/java and src/test/java respectively), even if they would be defined in an ancestor up the pom hierarchy. This issue at the time of writing has been addressed locally, PR incoming soon:tm:
      Ref: POM inheritance
    2. Spoon doesn't interpolate ${project.basedir}, which was encounted in some repos. PR mentioned above will also address this.
  2. Theory: in multi-maven-project scenarios (>1 pom.xml file in a repo), in root pom files that don't act as aggregators (aka don't define a <module> block), maven projects that aren't the root project would be missed, and therefore not indexed. This could be addressed in lsif-java itself by comparing the discovered-by-Spoon projects and comparing it to the discovered-by-filesystem-tree-walking pom.xml files/projects, and adding the missing projects to the Spoon model's input resources.
    Ref: POM aggregation
@Strum355 Strum355 added the type/bug Something isn't working label Sep 2, 2020
@Strum355 Strum355 self-assigned this Sep 2, 2020
@Strum355
Copy link
Contributor Author

Strum355 commented Sep 2, 2020

PR created @ INRIA/spoon#3562

@macraig
Copy link

macraig commented Nov 20, 2020

@Strum355 is this still relevant after switching away from Spoon?

@Strum355 Strum355 removed their assignment Feb 15, 2021
@olafurpg
Copy link
Member

Closing this since it's no longer relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants