fix: fetchin module from the JDT compiler #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
force-pushed
the
compunit-jdt-module
branch
3 times, most recently
from
9567ad5 to
6dd5a94
Compare
|
Could you move the change to |
Strum355
force-pushed
the
compunit-jdt-module
branch
from
6dd5a94 to
1f9876d
Compare
|
@Strum355 still draft here? Would you be able to add the corresponding test case? |
|
Thanks a lot for the test case! In Spoon, we try to always have a contract in natural language in each test, see the other Could you add this? Then we merge! |
|
Added some contracts, let me know if you'd like any amendments to them :) |
monperrus
changed the title
|
Thanks a lot @Strum355 |
This was referenced Sep 2, 2020
Strum355
added a commit
to Strum355/spoon
that referenced
this pull request
Sep 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm a new code intel SWE at Sourcegraph, and I'll be owning the https://github.com/sourcegraph/lsif-java project for the foreseeable time :)
We came across an issue with Java 9 modules (tracking here), and I discovered a relevant
TODOhttps://github.com/INRIA/spoon/blob/d7da4c6684/src/main/java/spoon/support/compiler/jdt/JDTBatchCompiler.java#L94The following screenshot gives some insight into the state leading up to the exception, where it seems to extract the wrong module name from the file folder
VSCode Java Debugger state
I havent tested this PR in multi-module scenarios, this was the simpler path instead of sorting
this.filenamesandthis.modNamesand determining the most recent module name (from the sorted list), given non module-info.java and package-info.java entries in this.filenames havenullset for their index inthis.modNames.If this doesn't work as expected in multi-module scenarios (which I will follow up on after this PR is made), this PR can be amended or a new one made for it.
Thanks :)
Note: I'm relying on CI tests to run as I'm unable to run them locally as of yet