bug: Spoon crashes because of module-info.java when building model #3417

henry-lp · 2020-06-14T10:07:23Z

java.lang.IllegalStateException: Module should be known was thrown when I load this project and tried to build a model with it. Before that Spoon demands that the compliance level should be set to 9 and the error was thrown after it was set in Spoon enviroment.

All other spoon configurations during run, please check this file

To reproduce :

git clone https://github.com/SpoonLabs/sorald.git

cd sorald

mvn package -DskipTests

git clone https://github.com/eclipse/openj9 Repo4Analyze

java -jar target/sorald-1.1-SNAPSHOT-jar-with-dependencies.jar --originalFilesPath Repo4Analyze/ --ruleKeys 2184 --maxFixesPerRule 1

Error output log:

Exception in thread "main" java.lang.IllegalStateException: Module should be known
	at org.eclipse.jdt.internal.compiler.batch.CompilationUnit.module(CompilationUnit.java:126)
	at org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.module(CompilationUnitDeclaration.java:847)
	at org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.buildTypeBindings(LookupEnvironment.java:470)
	at org.eclipse.jdt.internal.compiler.Compiler.internalBeginToCompile(Compiler.java:854)
	at org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:394)
	at spoon.support.compiler.jdt.TreeBuilderCompiler.buildUnits(TreeBuilderCompiler.java:60)
	at spoon.support.compiler.jdt.JDTBatchCompiler.getUnits(JDTBatchCompiler.java:256)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.buildUnits(JDTBasedSpoonCompiler.java:417)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.buildUnitsAndModel(JDTBasedSpoonCompiler.java:369)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.buildSources(JDTBasedSpoonCompiler.java:337)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.build(JDTBasedSpoonCompiler.java:114)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.build(JDTBasedSpoonCompiler.java:97)
	at spoon.Launcher.buildModel(Launcher.java:755)
	at sorald.DefaultRepair.createLauncher(DefaultRepair.java:128)
	at sorald.DefaultRepair.repair(DefaultRepair.java:60)
	at sorald.Main.start(Main.java:137)
	at sorald.Main.main(Main.java:143)

The text was updated successfully, but these errors were encountered:

monperrus · 2020-06-15T14:38:30Z

This depends on the used JVM.

Which JVM do you use? Could you try with some other versions?

darius-sas · 2020-09-03T14:06:35Z

Hi,

I'm encountering similar issues while analysing other projects as well.

Here are the details of my environment:

Java:

openjdk version "11.0.5" 2019-10-15
OpenJDK Runtime Environment (build 11.0.5+10-post-Ubuntu-0ubuntu1.119.04)
OpenJDK 64-Bit Server VM (build 11.0.5+10-post-Ubuntu-0ubuntu1.119.04, mixed mode, sharing)

Spoon:

<groupId>fr.inria.gforge.spoon</groupId>
<artifactId>spoon-core</artifactId>
<version>8.2.0</version>

Spoon Environment:

environment.setEncoding(StandardCharsets.UTF_8);
environment.disableConsistencyChecks();
environment.setComplianceLevel(9); // tried even with 13
environment.setIgnoreDuplicateDeclarations(true);
environment.setCommentEnabled(false);
environment.setNoClasspath(true);
environment.setShouldCompile(false);

This happens regardless of what Launcher I use, Launcher directly or MavenLauncher.
Tried different environment settings too, but no success so far.

At the moment, the only workaround I have for this issue is to ensure Spoon doesn't see the module-info.java file, by passing as input resource the src/main/java/com instead of src/main/java.

monperrus · 2020-09-04T19:58:45Z

Thanks for the additional info. Does the bug also happen with OpenJDK 9?

darius-sas · 2020-09-05T10:29:20Z

I cannot compile my project with Java 9 (only 11 or above), but I created a new project and get the same issue using OpenJDK 9 analysing Joda-Beans with the same settings I mentioned in my previous comment.

$ java -jar target/untitled-1.0-SNAPSHOT-jar-with-dependencies.jar joda-beans/src/main/java
Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Exception in thread "main" java.lang.IllegalStateException: Module should be known
	at org.eclipse.jdt.internal.compiler.batch.CompilationUnit.module(CompilationUnit.java:126)
	at org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.module(CompilationUnitDeclaration.java:847)
	at org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.buildTypeBindings(LookupEnvironment.java:470)
	at org.eclipse.jdt.internal.compiler.Compiler.internalBeginToCompile(Compiler.java:854)
	at org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:394)
	at spoon.support.compiler.jdt.TreeBuilderCompiler.buildUnits(TreeBuilderCompiler.java:60)
	at spoon.support.compiler.jdt.JDTBatchCompiler.getUnits(JDTBatchCompiler.java:256)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.buildUnits(JDTBasedSpoonCompiler.java:417)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.buildUnitsAndModel(JDTBasedSpoonCompiler.java:369)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.buildSources(JDTBasedSpoonCompiler.java:337)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.build(JDTBasedSpoonCompiler.java:114)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.build(JDTBasedSpoonCompiler.java:97)
	at spoon.Launcher.buildModel(Launcher.java:755)
	at com.company.Main.main(Main.java:42)

The Java version I used:

openjdk version "9.0.1"
OpenJDK Runtime Environment (build 9.0.1+11)
OpenJDK 64-Bit Server VM (build 9.0.1+11, mixed mode)

Link to download my test project:
untitled.zip

Commit hash of Joda beans: 6ffbe8ffe7ba64675158e0f6f5c47a190c45bb29

monperrus · 2020-09-07T06:49:43Z

Thanks.

We had a recent change in the module code #3549

Could you try with master?

darius-sas · 2020-09-07T11:33:36Z

Now it crashes with NullPointerException

$ java9 -jar target/untitled-8.3.0-SNAPSHOT-jar-with-dependencies.jar ~/data/repos/joda-beans/src
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Exception in thread "main" java.lang.NullPointerException
	at spoon.support.compiler.jdt.ReferenceBuilder.setPackageOrDeclaringType(ReferenceBuilder.java:1114)
	at spoon.support.compiler.jdt.ReferenceBuilder.getTypeReference(ReferenceBuilder.java:704)
	at spoon.support.compiler.jdt.ReferenceBuilder.getTypeReference(ReferenceBuilder.java:637)
	at spoon.support.compiler.jdt.ReferenceBuilder.getTypeReference(ReferenceBuilder.java:519)
	at spoon.support.compiler.jdt.ReferenceBuilder.buildTypeReference(ReferenceBuilder.java:136)
	at spoon.support.compiler.jdt.ReferenceBuilder.buildTypeReference(ReferenceBuilder.java:130)
	at spoon.support.compiler.jdt.ReferenceBuilder.buildTypeReference(ReferenceBuilder.java:148)
	at spoon.support.compiler.jdt.JDTTreeBuilder.visit(JDTTreeBuilder.java:1527)
	at org.eclipse.jdt.internal.compiler.ast.QualifiedTypeReference.traverse(QualifiedTypeReference.java:220)
	at org.eclipse.jdt.internal.compiler.ast.LocalDeclaration.traverse(LocalDeclaration.java:478)
	at org.eclipse.jdt.internal.compiler.ast.Block.traverse(Block.java:148)
	at org.eclipse.jdt.internal.compiler.ast.ForeachStatement.traverse(ForeachStatement.java:671)
	at org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.traverse(MethodDeclaration.java:365)
	at org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.traverse(TypeDeclaration.java:1591)
	at org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.traverse(TypeDeclaration.java:1463)
	at org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.traverse(CompilationUnitDeclaration.java:826)
	at org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.traverse(CompilationUnitDeclaration.java:787)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.lambda$buildModel$0(JDTBasedSpoonCompiler.java:437)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.forEachCompilationUnit(JDTBasedSpoonCompiler.java:466)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.buildModel(JDTBasedSpoonCompiler.java:435)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.buildUnitsAndModel(JDTBasedSpoonCompiler.java:372)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.buildSources(JDTBasedSpoonCompiler.java:337)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.build(JDTBasedSpoonCompiler.java:114)
	at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.build(JDTBasedSpoonCompiler.java:97)
	at spoon.Launcher.buildModel(Launcher.java:755)
	at com.company.Main.main(Main.java:43)

monperrus · 2020-09-11T05:33:32Z

Would you be able to write a failing test case in a pull request? That would be super helpful.

slarse · 2021-08-12T13:41:01Z

I believe that this was fixed in #4073, I now have no trouble parsing Joda-Beans commit 6ffbe8ffe7ba64675158e0f6f5c47a190c45bb29.

@darius-sas can you confirm that the problem is solved on your end?

darius-sas · 2021-08-13T08:08:05Z

Works for me too!
Thanks for fixing.

slarse · 2021-08-13T08:55:36Z

@darius-sas Thanks for confirming, I'm closing this issue then :)

monperrus changed the title ~~A way to ignore Module when building model~~ bug; Spoon crashes because of module-info.java when building model Sep 11, 2020

monperrus changed the title ~~bug; Spoon crashes because of module-info.java when building model~~ bug: Spoon crashes because of module-info.java when building model Sep 11, 2020

monperrus added the bug label Sep 11, 2020

slarse closed this as completed Aug 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug: Spoon crashes because of module-info.java when building model #3417

bug: Spoon crashes because of module-info.java when building model #3417

henry-lp commented Jun 14, 2020 •

edited

Loading

monperrus commented Jun 15, 2020

darius-sas commented Sep 3, 2020 •

edited

Loading

monperrus commented Sep 4, 2020

darius-sas commented Sep 5, 2020

monperrus commented Sep 7, 2020

darius-sas commented Sep 7, 2020

monperrus commented Sep 11, 2020

slarse commented Aug 12, 2021

darius-sas commented Aug 13, 2021

slarse commented Aug 13, 2021

bug: Spoon crashes because of module-info.java when building model #3417

bug: Spoon crashes because of module-info.java when building model #3417

Comments

henry-lp commented Jun 14, 2020 • edited Loading

monperrus commented Jun 15, 2020

darius-sas commented Sep 3, 2020 • edited Loading

monperrus commented Sep 4, 2020

darius-sas commented Sep 5, 2020

monperrus commented Sep 7, 2020

darius-sas commented Sep 7, 2020

monperrus commented Sep 11, 2020

slarse commented Aug 12, 2021

darius-sas commented Aug 13, 2021

slarse commented Aug 13, 2021

henry-lp commented Jun 14, 2020 •

edited

Loading

darius-sas commented Sep 3, 2020 •

edited

Loading