Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTI: Adding the php-jwt dependency to the composer.json file and update the composer.lock file #8216

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ZallaxDev
Copy link
Contributor

We integrate the php-jwt dependency as it is required for the LTI and LTIConsumer components to work.
This dependency is secure as it is officially supported by the team behind Firebase at Google. It is kept up to date, allowing compatibility with modern versions of PHP, requiring the current version to be at least PHP 8 or higher.
No better alternatives have been found with this support, maintenance and compatibility.
The inclusion of these dependencies will allow the removal of the 'src' folder included in the LTI component and make it easier to upgrade these components in the future.

…e composer.lock file

The composer.json file has been modified to include the php-jwt dependency, required in the LTI module to stop including external libraries inside the module itself.
Additionally, the composer.lock file has been updated to reflect the changes in dependencies, ensuring consistent versions across different environments.
@ZallaxDev ZallaxDev added improvement dependencies Pull requests that update a dependency file labels Oct 18, 2024
@ZallaxDev ZallaxDev merged commit f674efa into ILIAS-eLearning:trunk Oct 21, 2024
1 of 3 checks passed
@dsstrassner
Copy link
Contributor

JF Decision is in #8181 and was at 14. OCT 2024

@ZallaxDev ZallaxDev deleted the trunk_LTI_002 branch November 4, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants