-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trunk LTI 001 - Adding dependencies & LTI Provider folder renaming #8181
Conversation
The composer.json file has been modified to include the php-jwt dependency, required in the LTI module to stop including external libraries inside the module itself.
The composer.json file has been modified to include the LTI-PHP dependency, required in the LTI module to stop including external libraries inside the module itself.
The LTI folder has been renamed to LTIProvider to maintain better consistency in component names.
Work in progress :) |
The composer.lock resulting from the installation of the php-jwt and LTI-PHP dependencies has been added.
This comment was marked as resolved.
This comment was marked as resolved.
Hi @jcopado , just one thought on this: If you want to make these dependencies explicit (which is good, thanks a lot) by adding them to the See also: https://github.com/ILIAS-eLearning/ILIAS/blob/trunk/vendor/README.md Best regards, |
Jour Fixe, 14 OCT 2024: Thanks for the PR. We accept the dependencies and renaming. But we prefer to split up the PR into three PRs, each dedicated to one subject: one for adding 'php-jwt', one for adding 'LTI-PHP' and one for renaming the 'LTI' directory to 'LTI Provider'. |
hi @jcopado & @ZallaxDev with the merge of #8232 and #8220 and #8216, this PR could be closed? |
The composer.json file has been modified to include the php-jwt and LTI-PHP dependencies, required in the LTI module to stop including external libraries inside the module itself.
The LTI folder has been renamed to LTIProvider to maintain better consistency in component names.