-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Service: Dropzones #586
Merged
chfsx
merged 213 commits into
ILIAS-eLearning:trunk
from
srsolutionsag:feature/5-3/ui-service-dropzones-2
Aug 16, 2017
+94,918
−9
Merged
Changes from 1 commit
Commits
Show all changes
213 commits
Select commit
Hold shift + click to select a range
1f96a8c
Create basic interface structure for file dropzones.
8dc546a
Create basic class structure for file dropzones.
63fc928
Add phpdoc comments and implement interface methods.
3687895
Add phpdoc comments and needed private methods.
703985a
Add dropzone.js library to templates.
3f4dbaa
Create template for standard file dropzone.
ac67831
Add description and implementation for file dropzones to the UI Factory.
294c522
Create unit test FileDropzoneRendererer render standard dropzone.
0641d23
Merge branch 'trunk' into feature/5-3/ui-service-dropzones
d80f0de
Fix type hint error.
20ea633
Fix id in expected html.
d6291df
Implement unit test FileDropzoneRenderer render standard dropzone.
3e2cfc5
Add fileDropzone method.
9b98fe7
Fix method scope problem.
6b9fed5
Add less for drop zones.
a490664
Add javascript for drop zones.
809f5e9
Import dropzone less.
9c2283e
Add FileDropzone Standard example.
713907d
Add css class .standard
7b69065
Register dropzone.js resource.
4b35cee
Create unit test FileDropzoneRenderer render wrapper dropzone.
2bb03bc
Create wrapper dropzone template.
624bd1b
Override normalizeHtml method and fix spelling error in expected html.
0891f83
Implement unit test FileDropzone Renderer render wrapper dropzone.
5140de8
Create unit test FileDropzone Renderer render standard drop zone with…
f946b6e
Implement unit test FileDropzone Renderer render standard dropzone wi…
ec85cc7
Make Wrapper Dropzone with constructor argument.
2d394fb
Fix unit test with Wrapper Dropzone constructor argument.
4820db3
Add method checkEmptyArray().
74caee5
Make the methods scope public.
7974fa1
Refactor FileDropzone Renderer.
fb69840
Make the methods scope public.
84b53d8
Add example FileDropzone Standard with default message.
90c9cab
Add example FileDropzone with alternative highlight.
f89aab2
Create basic class structure.
37fed19
Add phpdoc comments.
9973555
Create unit test JavascriptHelper enable drop design.
2b7617a
Implement unit test JavascriptHelper enable drop design.
8171102
Create unit test JavascriptHelper disable drop design.
506ad69
Implement unit test JavascriptHelper disable drop design.
162c35e
Create unit test JavascriptHelper initialize drop zone.
5c4b8f5
Implement unit test JavascriptHelper initialize dropzone.
6e806a9
Create unit test JavascriptHelper trigger signals.
688314c
Implement unit test JavascriptHelper trigger signals.
317d072
Remove php7 syntax.
363ee4c
Update expected javascript in JavascriptHelperTest.
7f65b7b
Update JavascriptHelper with js function in string.
9fd7799
Add wrappToJSEventFunction method.
72a3e47
Add javascript onload code for dropzones.
17bad8e
Add phpdoc and refactor method wrapToJSEventFunction.
2ce1aef
Add the previewsContainer options the javascript code.
e00ae5c
Add phpdoc comments.
dfaf8f3
Add jsdoc to functions.
37a67d9
Add registeredSignals variable.
3879664
Update unit tests JavascriptHelper with updated expected javascript c…
e59a2d8
Implement updated unit test for JavascriptHelper class.
c85a2bd
Remove private variable $darkendBackground.
eac34e6
Add javascript functions to enable darkened Design for a dropzone.
54e0591
Update renderer for Standard Dropzone with the new javascript code.
f84a73c
Update phpdoc for Standard Dropzone.
731fc11
Update Standard Dropzone example with darkened background option.
8befee3
Delete outdated example.
5c4edb1
Update css for Standard Dropzone.
1c0c373
Add private variable $darkedBackground.
329f345
Set $darkendBackground to true in constructor.
4e7b2e8
Change $darkendBackground to false and make its scope protected.
e0af1ed
Update javascript unload code in FileDropzone Renderer.
83508c1
Create Wrapper Dropzone example.
57144b0
Add css for wrapper drop zones.
91c389c
Add Wrapper Dropzone example with alternativeDesign.
add2640
Add css for wrapper dropzone with darkened background.
a564069
Fix spelling error.
98705a6
Add javascript doc comments.
34c1d8d
Make argument for wrapper content to array or Component.
ff45787
Rename DefaultMassage to message for methods and variables.
6513a61
Change parameter to array or Component type.
1fbfa41
Add jQuery dragster library.
61ad645
Extend JavascriptHelper class with additional Javascript code for dro…
c3f3390
Add additional javascript functions for dropzones.
2b81712
Reimplement javascript setup for wrapper dropzones.
01d0059
Update css less for drop zones.
a4be402
Make JavascriptHelper class more responsible to render javascript cod…
4ac653c
Delete unnecessary unit test for JavascriptHelper class.
c8dfae0
Extend javascript functions for the dropzone behavior.
cb255a3
Update the javascript function name.
0f72b2c
Exclude javascript code into JavascriptHelper class.
142ee90
Add variable to contain css selectors which are used.
01aacc4
Remove unnecessary div tag.
e316560
Remove dropzone.js library.
2ec6c8c
Add default design function for drop zones.
b96f4a0
Fix css classes for default design.
5e2c779
Make SimpleDropzone class able to hold the option to auto discovery t…
cf5037d
Fix spelling error in comment.
db0805e
Use setter chaining for SimpleDropzone instances.
40fb58e
Update php doc comments for wrapper and standard drop zone.
19c4ff6
Fix php7 syntax.
e231ff4
Update examples for dropzones.
cb5ca01
Rename function to withMessage.
8dd874a
Delete example for file dropzone with wrong name.
b5f60be
Add less variables for dropzone styles.
8f34eec
Add public scope to methods.
addac8c
Add full namespace to phpdoc @return stamement.
a1e0604
Update phpdoc comments of the Droppable interface.
0932310
Rename BasicFileDropzone interface to FileDropzone.
6dc0619
Rename FileDropzone to Dropzone.
602b651
Fix spelling error darkend -> darkened.
a037ee9
Rename “file dropzone” to “dropzone”.
45fa917
Update php doc comment.
46cbc86
Move jQuery dragster to the libs directory.
62b50ef
Add ComponentHelper.
69e564e
Add missing return statement.
1b26975
Rename fileDropzone() method to dropzone().
835fb78
Update dropzone description in the factory classes.
5f30b60
Fix spelling error in method call.
109cee3
Rename directory for examples from FileDropzone to Dropzone.
cfc3c55
Delete dropzone examples in wrong directory.
dfa225d
Reimplement the dropzone behavior.
270b3dd
Remove File Dropzone js.
fc4be81
Update SimpleDropzone with type attribute.
4e77cfd
Create class JSDropzoneInitializer and add basic methods.
79e26d2
Fix arg list check method call.
3378ad3
Add phpdoc comments.
be84ee6
Prevent defaults on browser drop events and update js doc.
6b55d34
Add authors email.
0b62fdc
Update dropzone init.
6c6c69c
Implement Wrapper drop zone behavior.
3ccfe26
Remove JavascriptHelper class.
41048a7
Update DropzoneRendererTest.
99aafcb
Remove old FileDropzoneRendererTest.
77dff79
Remove default from method name.
31dfa89
Create unit test cases for JSDropzoneInitializer class.
baa040d
Update jsdoc comment.
df193e8
Optimize rendering of dropzone content.
c83afcc
Fix bug when a signal is not used as string.
29ea4af
Move Dropzone to Dropzone/File.
d346111
Fix namespace errors.
4820e55
Delete old drop zone templates.
b7e65b1
Move unit tests to the File directory.
c292030
Delete old unit tests.
9066b13
Fix bug with jQuery foreach.
d1a0a9d
code-format proposal
chfsx 5317d5e
code-format II
chfsx cc0ce30
Merge branch 'feature/5-3/ui-service-dropzones-codeformat' into 'feat…
c3f4938
Fix yaml parse errors.
a408a49
Implement upload-container.js.
105b8c5
Implement uploader.js component.
436f0ae
Extend dropzone-behavior.js with the Upload dropzone component.
a0fe5e4
Add additional attributes for dropzones.
5555236
Add additional attributes in the json options parameter.
1af127b
Register upload-container.js and uploader.js.
08bd755
Fix path to js resource.
dd193ee
Fix event.dataTransfer call and $.each loop.
2a568ae
Update type of ajax request.
50c8d39
Implement server side part of “proof of concept” upload dropzone and …
wanze f197f03
Add fineuploader library as upload dependency
wanze 58cb103
Implement JS wrapper to upload files (WIP)
wanze 096c4b6
Add validation for file uploads: Allowed file types, Max file size, M…
wanze d24eb72
Refactoring of file dropzones
wanze 15ff641
Update factory descriptions and add a proof of concept of how one can…
wanze 3626f8d
Merge branch 'trunk' into feature/5-3/ui-service-dropzones-2
wanze 06a1d4f
Extend javascript wrapper of uploader with the possbility to bind upl…
wanze 0dfe022
Update examples, update factory descriptions and fix rendering unit t…
wanze c10faf2
Remove some unecessary files of 3thparty dependency “FineUploader”
wanze a4dc212
Some updates after feedback on pull request, mainly factory descripti…
wanze e1d0d5b
added bower dependency description
chfsx 32d2a83
Merge branch 'trunk' into feature/5-3/ui-service-dropzones-2
chfsx 41eeebf
Merge branch 'proposal/5-3/bower' into feature/5-3/ui-service-dropzon…
chfsx fb06b73
switched to bower for JS-dependency, another PR will be opened for th…
chfsx b888b6a
updated KS-data
chfsx afa019b
corrected some naming on Droppable
chfsx d016585
renaming some methods in both interface and implementation based on f…
chfsx a2d9be1
switched jquery.dragster.js to bower
chfsx 6add51d
withUserDefinedDescriptionEnabled and withUserDefinedFileNamesEnabled
chfsx 52eac04
first attempt to implement #578
chfsx fe2fe6e
fixed two small BT tasks
chfsx 935e3b2
Merge branch 'trunk' into feature/5-3/ui-service-dropzones-2
chfsx 19b6994
dropzone-specific css rendered
chfsx fa8b081
implemented more accurate version of the standard-dropzone as discuss…
chfsx 4209c2d
language improvements for DZ
chfsx eac8ccb
finalized standard dropzone and prototype of usage in standard (legac…
chfsx d3cacc6
finished implementation of wrapper dropzone
chfsx 5c0a89a
missed template file in commit
chfsx 6aad4ae
Merge branch 'trunk' into feature/5-3/ui-service-dropzones-2
chfsx 6283e43
implemented alternative version of filelists in d&d uploads
chfsx 2b4db82
fixed margin of closebutton within the filelist
chfsx 479d459
again the margin...
chfsx a35c391
changes due to integration in legacy forms
chfsx 7d15ba6
updated classmap
chfsx 293911f
moved ilFileStandardDropzoneGUI
chfsx 34546be
updated classmap
chfsx f7e72c5
latest changes to form-usage of dropzones
chfsx f3e03e1
coding conventions
chfsx a325c36
implemented stronger rule for wrapper-dz
chfsx ed34979
Updated Tests
chfsx e3eb8fa
added additional tests for dropzones
chfsx 3a22fee
Merge branch 'trunk' into feature/5-3/ui-service-dropzones-2
chfsx 3703fca
comment why the ilFileStandardDropzoneInputGUI is not a replacement f…
chfsx debbdbe
describing the public interface of ilFileStandardDropzoneInputGUI
chfsx b11be2d
moved ilFileStandardDropzoneInputGUI.js out of examples to a more app…
chfsx a31abe0
removed @version descriptions
chfsx 59d3abc
renamed withIdentifier to withParameterName
chfsx 2e08d94
comment for the drop-event
chfsx 97e4e9c
comments in the Examples
chfsx bada67b
removed debugging in ilFileStandardDropzoneInputGUI.js
chfsx 6ea9296
descriptions in Wrapper-Dropzone Examples
chfsx 559d676
commented out log() in uploader.js
chfsx d9d6be6
removed logging in dropzone.js
chfsx d39ece7
removed another @version
chfsx 07b2516
describing public method
chfsx 8019727
use withAdditionalOnLoadCode() for the upload button
chfsx fe9a2ba
!important; no longer needed
chfsx 0fac873
removed unused jquery.dragster
chfsx 954a27c
push those libraries for tho moment, if #608 won't be accepted we wil…
chfsx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
renamed withIdentifier to withParameterName
- vrelease_7
- v11.0_alpha
- v10.0_beta1
- v9.6
- v9.5
- v9.4
- v9.3
- v9.2
- v9.1
- v9.0
- v9.0_beta3
- v9.0_beta2
- v9.0_beta1
- v8.17
- v8.16
- v8.15
- v8.14
- v8.13
- v8.12
- v8.11
- v8.10
- v8.9
- v8.8
- v8.7
- v8.6
- v8.5
- v8.4
- v8.3
- v8.2
- v8.1
- v8.0
- v8.0_beta4
- v8.0_beta3
- v8.0_beta2
- v8.0_beta1
- v7.30
- v7.29
- v7.28
- v7.27
- v7.26
- v7.25
- v7.24
- v7.23
- v7.22
- v7.21
- v7.20
- v7.19
- v7.18
- v7.17
- v7.16
- v7.15
- v7.14
- v7.13
- v7.12
- v7.11
- v7.10
- v7.9
- v7.8
- v7.7
- v7.6
- v7.5
- v7.4
- v7.3
- v7.2
- v7.1
- v7.0
- v7.0_beta4
- v7.0_beta3
- v7.0_beta2
- v7.0_beta1
- v6.24
- v6.23
- v6.22
- v6.21
- v6.20
- v6.19
- v6.18
- v6.17
- v6.16
- v6.15
- v6.14
- v6.13
- v6.12
- v6.11
- v6.10
- v6.9
- v6.8
- v6.8-1
- v6.7
- v6.6
- v6.5
- v6.4
- v6.3
- v6.2
- v6.1
- v6.0
- v6.0_beta2
- v6.0_beta1
- v5.4.26
- v5.4.25
- v5.4.24
- v5.4.23
- v5.4.22
- v5.4.21
- v5.4.20
- v5.4.19
- v5.4.18
- v5.4.17
- v5.4.16
- v5.4.15
- v5.4.14
- v5.4.13
- v5.4.12
- v5.4.11
- v5.4.10
- v5.4.9
- v5.4.8
- v5.4.7
- v5.4.6
- v5.4.5
- v5.4.4
- v5.4.3
- v5.4.2
- v5.4.1
- v5.4.0
- v5.4.0-beta.1
- v5.3.23
- v5.3.22
- v5.3.21
- v5.3.20
- v5.3.19
- v5.3.18
- v5.3.17
- v5.3.16
- v5.3.15
- v5.3.14
- v5.3.13
- v5.3.12
- v5.3.11
- v5.3.10
- v5.3.9
- v5.3.8
- v5.3.7
- v5.3.6
- v5.3.5
- v5.3.4
- v5.3.3
- v5.3.2
- v5.3.1
- v5.3.0
- v5.3.0beta4
- v5.3.0beta3
- v5.3.0beta2
- v5.3.0beta1
- v5
- test
- show
commit 59d3abcc6c417576c9973fc9e4129f5baf0f6290
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the much improved generation of this options as json!