UI Service: Dropzones #586
Conversation
… default message.
…th default message.
There was a problem hiding this comment.
Thank you for this enhancement. I think there is a lot of brainfood in here that we can build up on in later components. Some aspects might certainly be refined as the framework evolves but I think think this is a big step forward.
See comments for minor corrections.
| /* Copyright (c) 1998-2009 ILIAS open source, Extended GPL, see docs/LICENSE */ | ||
|
|
||
| /** | ||
| * This class represents a file property in a property form. |
There was a problem hiding this comment.
Please describe here shortly the relation to the new UI service and why this class is needed.
| /** | ||
| * @var int | ||
| */ | ||
| static $count = 0; |
There was a problem hiding this comment.
Describe what this variable does here.
| /** | ||
| * @var string | ||
| */ | ||
| protected $upload_url = ''; |
There was a problem hiding this comment.
Describe what this variable does here.
| /** | ||
| * @var int | ||
| */ | ||
| protected $max_files = 1; |
There was a problem hiding this comment.
Describe what this variable does here.
| /** | ||
| * @var \ILIAS\Data\DataSize | ||
| */ | ||
| protected $max_file_size; |
There was a problem hiding this comment.
Describe what this variable does here.
| * | ||
| * @param {boolean} darkenedBackground true to use the darkened background for highlighting, otherwise false | ||
| * | ||
| * @private |
There was a problem hiding this comment.
Somehow clear, since they are not exposed, but .i.O..
There was a problem hiding this comment.
This is another jsDoc thingy, will put that to the JS-Readme PR later
| options.fileListContainer = $dropzone.find('.il-modal-roundtrip').find('.il-upload-file-list'); | ||
| options.uploadButton = $dropzone.find('.modal-footer a.btn-primary:first'); | ||
|
|
||
| console.log(options); |
| @@ -0,0 +1,85 @@ | |||
| // 1.0.3 | |||
There was a problem hiding this comment.
Please move to global bower libs as soon as accepted by JF and available in core, see other PR concerning this. If not accepted, this may stay.
| @il-dropzone-filelist-border-color: @il-dropzone-border-color; | ||
| @il-dropzone-filelist-border-type: solid; | ||
| @il-dropzone-filelist-border-width: @il-dropzone-border-width; | ||
| @il-dropzone-filelist-border-radius: @il-dropzone-border-radius; |
There was a problem hiding this comment.
Thanks for this well chosen set of variables.
| * Adds a html div to enable the darkened background, if the passed in argument is true. | ||
| * Sets the state of the darkened background availability to the value of the passed in argument. | ||
| * | ||
| * @param {boolean} darkenedBackground true, if the darkened background should be available |
There was a problem hiding this comment.
Is this derived from some standard on how to add docComments on JS? if yes, adjust the readme of the UI-Framework.
…or all ilFileInputGUI
|
@Amstutz Thank you very much for your feedback I (hope) I tackled all of your comments with my last commits except of those concerning "withAdditionalOnLoadCode" which need some more time. |
|
@klees still is there something missing for your approval? Note that if no further objections are voiced, this will be merged in the day. |
…accepted we will move the libraries out or /libs to /src/UI
|
I added the JS-libraries in the libs/bower directory, but if PR #603 won't be accepted we will move them out of this location to src/UI |
Proposal for the interfaces of file dropzones, allowing to drag and drop files and the upload process to the server. Two types of dropzones are introduced:
Please note: Although this pull request contains a working implementation, we encourage to mainly discuss the introduced interfaces here, due to the complexity of file uploads.
Factory Descriptions: https://github.com/ILIAS-eLearning/ILIAS/pull/586/files#diff-c0ddc616843072099030db8c4a168890R17
Common Interface for file drozpones: https://github.com/studer-raimann/ILIAS/blob/a4dc212d5715ea6758c26015af64cc8d06bccedb/src/UI/Component/Dropzone/File/File.php
Interface standard dropzone: https://github.com/studer-raimann/ILIAS/blob/a4dc212d5715ea6758c26015af64cc8d06bccedb/src/UI/Component/Dropzone/File/Standard.php
Interface wrapper dropzone: https://github.com/studer-raimann/ILIAS/blob/a4dc212d5715ea6758c26015af64cc8d06bccedb/src/UI/Component/Dropzone/File/Wrapper.php