Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Take SAHS display options into account #4622

Merged

Conversation

lscharmer
Copy link
Contributor

Mantis: https://mantis.ilias.de/view.php?id=31745

The Dashboard uses the ilObjectListGUI::getAsListItem method to create a list item.
The ilObjectListGUI::getAsListItem method does not use the ilObjectListGUI::modifySAHSlaunch and does not set the target attribute to the anchor when it is needed.

@lscharmer lscharmer added bugfix php Pull requests that update Php code labels May 31, 2022
@iszmais iszmais self-assigned this Jun 3, 2022
Copy link
Contributor

@iszmais iszmais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @lscharmer for the solution!

Looks good and seems to work. 👍

Greetings @iszmais

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants