Skip to content

Commit

Permalink
Add call to modifySAHSlaunch in ilObjectListGUI::getAsListItem
Browse files Browse the repository at this point in the history
  • Loading branch information
lscharmer committed May 31, 2022
1 parent 5f7d680 commit 8e4fb17
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion Services/Object/classes/class.ilObjectListGUI.php
Original file line number Diff line number Diff line change
Expand Up @@ -3793,7 +3793,13 @@ public function getAsListItem(


if ($def_command['link']) {
$list_item = $ui->factory()->item()->standard($this->ui->factory()->link()->standard($this->getTitle(), $def_command['link']));
$def_command['link'] = $this->modifySAHSlaunch($def_command['link'], $def_command['frame']);
$new_viewport = (bool) $this->getDefaultCommand()['frame']; // Cannot use $def_command['frame']. $this->default_command has been edited.
$link = $this->ui->factory()
->link()
->standard($this->getTitle(), $def_command['link'])
->withOpenInNewViewport($new_viewport);
$list_item = $ui->factory()->item()->standard($link);
} else {
$list_item = $ui->factory()->item()->standard($this->getTitle());
}
Expand Down

6 comments on commit 8e4fb17

@iljalukin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change causes objects on the dashboard to open in a new window, which might not be the desired behavior.

@lscharmer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change causes objects on the dashboard to open in a new window, which might not be the desired behavior.

Could you elaborate this. Do you mean all objects or some objects in certain contexts?

@iljalukin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It affects all objects in the list view and can be observed on docu.ilias.de.

@lscharmer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I could not reproduce this yet on my local instances but I will fix this. Thank you for your feedback.

@lscharmer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is created: #4677 and #4678

@iljalukin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please sign in to comment.