Badges: Fix missing table id and sorting issues

(cherry picked from commit 7fbabba)
ILIAS-eLearning · Dec 18, 2024 · 6273736 · 6273736
1 parent fbe18b8
commit 6273736
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/components/ILIAS/Badge/classes/class.ilBadgeImageTemplateTableGUI.php b/components/ILIAS/Badge/classes/class.ilBadgeImageTemplateTableGUI.php
@@ -64,8 +64,8 @@ private function buildDataRetrievalObject(Factory $f, Renderer $r): DataRetrieva
     {
         return new class ($f, $r) implements DataRetrieval {
             public function __construct(
-                private Factory $ui_factory,
-                private Renderer $ui_renderer
+                private readonly Factory $ui_factory,
+                private readonly Renderer $ui_renderer
             ) {
             }
 

diff --git a/components/ILIAS/Badge/classes/class.ilBadgeTypesTableGUI.php b/components/ILIAS/Badge/classes/class.ilBadgeTypesTableGUI.php
@@ -65,8 +65,8 @@ private function buildDataRetrievalObject(Factory $f, Renderer $r): DataRetrieva
     {
         return new class ($f, $r) implements DataRetrieval {
             public function __construct(
-                private Factory $ui_factory,
-                private Renderer $ui_renderer
+                private readonly Factory $ui_factory,
+                private readonly Renderer $ui_renderer
             ) {
             }
 

diff --git a/components/ILIAS/Badge/classes/class.ilObjectBadgeTableGUI.php b/components/ILIAS/Badge/classes/class.ilObjectBadgeTableGUI.php
@@ -54,8 +54,8 @@ class ilObjectBadgeTableGUI
     private readonly Services $http;
     private readonly ilLanguage $lng;
     private readonly ilGlobalTemplateInterface $tpl;
-    private ilObjBadgeAdministrationGUI $parent_obj;
-    private ilAccess $access;
+    private readonly ilObjBadgeAdministrationGUI $parent_obj;
+    private readonly ilAccess $access;
 
     public function __construct(ilObjBadgeAdministrationGUI $parentObj)
     {
@@ -87,9 +87,9 @@ private function buildDataRetrievalObject(
             private \ilAccessHandler $access;
 
             public function __construct(
-                private Factory $ui_factory,
-                private Renderer $ui_renderer,
-                private ilObjBadgeAdministrationGUI $parent
+                private readonly Factory $ui_factory,
+                private readonly Renderer $ui_renderer,
+                private readonly ilObjBadgeAdministrationGUI $parent
             ) {
                 global $DIC;