Skip to content

Commit

Permalink
Badges: Fix missing table id and sorting issues
Browse files Browse the repository at this point in the history
(cherry picked from commit d60af86)
  • Loading branch information
mjansenDatabay committed Dec 18, 2024
1 parent 74b5f27 commit fbe18b8
Showing 1 changed file with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function __construct(
/**
* @return list<array{id: int, image: string, title: string}>
*/
private function getBadgeImageTemplates(Container $DIC): array
private function getBadgeImageTemplates(): array
{
$modal_container = new ModalBuilder();
$rows = [];
Expand All @@ -88,7 +88,7 @@ private function getBadgeImageTemplates(Container $DIC): array
$badge_template_image,
$template->getTitle()
);
$image_html = $DIC->ui()->renderer()->render($image_component);
$image_html = $this->ui_renderer->render($image_component);

$badge_template_image_large = $template->getImageFromResourceId(
$template->getImageRid(),
Expand Down Expand Up @@ -146,9 +146,7 @@ public function getTotalRowCount(
*/
private function getRecords(Range $range = null, Order $order = null): array
{
global $DIC;

$rows = $this->getBadgeImageTemplates($DIC);
$rows = $this->getBadgeImageTemplates();

if ($order) {
[$order_field, $order_direction] = $order->join(
Expand Down

0 comments on commit fbe18b8

Please sign in to comment.