Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace outdated df append #544

Merged
merged 7 commits into from
Jun 28, 2022
Merged

Conversation

vBassewitz
Copy link
Contributor

@vBassewitz vBassewitz commented Jun 28, 2022

Description

fix: df.append is outdated and replaced by pd.concat

Related Issue

#496

Checklist

@vBassewitz vBassewitz requested a review from alethomas June 28, 2022 10:27
@vBassewitz vBassewitz changed the title Replace outdated df append fix: Replace outdated df append Jun 28, 2022
workflow/scripts/evaluate-strain-call-error.py Outdated Show resolved Hide resolved
workflow/scripts/extract-strains-from-gisaid-provision.py Outdated Show resolved Hide resolved
workflow/scripts/generate-overview-table.py Outdated Show resolved Hide resolved
workflow/scripts/plot-all-coverage.py Outdated Show resolved Hide resolved
workflow/scripts/plot-assembly-comparison.py Outdated Show resolved Hide resolved
workflow/scripts/generate-lineage-variant-table.py Outdated Show resolved Hide resolved
workflow/scripts/generate-lineage-variant-table.py Outdated Show resolved Hide resolved
workflow/scripts/plot-assembly-comparison.py Outdated Show resolved Hide resolved
workflow/scripts/plot-assembly-comparison.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@alethomas alethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Some minor changes

@vBassewitz vBassewitz merged commit 4a40003 into master Jun 28, 2022
@vBassewitz vBassewitz deleted the replace-outdated-df-append branch June 28, 2022 15:20
lenakinzel added a commit that referenced this pull request Jul 13, 2022
* chore(deps): bump pre-commit/action from 2.0.3 to 3.0.0 (#542)

Bumps [pre-commit/action](https://github.com/pre-commit/action) from 2.0.3 to 3.0.0.
- [Release notes](https://github.com/pre-commit/action/releases)
- [Commits](pre-commit/action@v2.0.3...v3.0.0)

---
updated-dependencies:
- dependency-name: pre-commit/action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: voc probability (#541)

* fix: Replace outdated df append (#544)

* replaced all df.append with pd.concat

* replaced df.append with pd.concat

* replace df.append with pd.concat

* replaced df.append with pd.concat

* replaced df.append with pd.concat

* replaced df.append with pd.concat

Co-authored-by: lenakinzel <[email protected]>
Co-authored-by: Alexander Thomas <[email protected]>

* refactor: fgbio read clipping (#545)

* change primer file formatting

* change read clipping

* fmt

* fix primer clipping plot

* fix primer clipping plot

* fix

* fix

* typo

* test

* Update pangolin to 4.1 (#546)

Co-authored-by: thomasbtf <[email protected]>
Co-authored-by: Ann-Kathrin Brüggemann <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Thomas <[email protected]>
Co-authored-by: vBassewitz <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: thomasbtf <[email protected]>
Co-authored-by: Ann-Kathrin Brüggemann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants