-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Replace outdated df append #544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vBassewitz
changed the title
Replace outdated df append
fix: Replace outdated df append
Jun 28, 2022
alethomas
requested changes
Jun 28, 2022
alethomas
requested changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Some minor changes
alethomas
approved these changes
Jun 28, 2022
lenakinzel
added a commit
that referenced
this pull request
Jul 13, 2022
* chore(deps): bump pre-commit/action from 2.0.3 to 3.0.0 (#542) Bumps [pre-commit/action](https://github.com/pre-commit/action) from 2.0.3 to 3.0.0. - [Release notes](https://github.com/pre-commit/action/releases) - [Commits](pre-commit/action@v2.0.3...v3.0.0) --- updated-dependencies: - dependency-name: pre-commit/action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: voc probability (#541) * fix: Replace outdated df append (#544) * replaced all df.append with pd.concat * replaced df.append with pd.concat * replace df.append with pd.concat * replaced df.append with pd.concat * replaced df.append with pd.concat * replaced df.append with pd.concat Co-authored-by: lenakinzel <[email protected]> Co-authored-by: Alexander Thomas <[email protected]> * refactor: fgbio read clipping (#545) * change primer file formatting * change read clipping * fmt * fix primer clipping plot * fix primer clipping plot * fix * fix * typo * test * Update pangolin to 4.1 (#546) Co-authored-by: thomasbtf <[email protected]> Co-authored-by: Ann-Kathrin Brüggemann <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexander Thomas <[email protected]> Co-authored-by: vBassewitz <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: thomasbtf <[email protected]> Co-authored-by: Ann-Kathrin Brüggemann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: df.append is outdated and replaced by pd.concat
Related Issue
#496
Checklist
pre-commit
if needed.CODE_OF_CONDUCT.md
document.CONTRIBUTING.md
guide.