Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recipe #0013 — Poster Image Displayed Before Interaction #151

Merged
merged 41 commits into from
Aug 24, 2020
Merged

Recipe #0013 — Poster Image Displayed Before Interaction #151

merged 41 commits into from
Aug 24, 2020

Conversation

triplingual
Copy link
Contributor

This PR addresses issue #13, showing something (a placeholderCanvas) to the user to view before they choose to start interacting with the object and/or while they wait for it to load/buffer.

@glenrobson
Copy link
Member

(Automated comment): Branch available for testing at https://preview.iiif.io/cookbook/0013-placeholderCanvas

@glenrobson
Copy link
Member

I asked on the UV slack and it looks like it implements posterCanvas here which was the original name for the field before it was renamed placeholderCanvas here.

@glenrobson glenrobson mentioned this pull request Jun 24, 2020
Open
3 tasks
@github-actions github-actions bot temporarily deployed to stagging July 2, 2020 12:20 Inactive
@github-actions github-actions bot temporarily deployed to stagging July 8, 2020 13:00 Inactive
@glenrobson
Copy link
Member

Comments from Cookbook editors:

They are happy to send it to the TRC with the following changes:

  • Use case: can you make the use case more specific. Talk about using a large video and and showing a image while it loads.
  • Could you change "Note: The placeholderCanvas property for time-based objects is not yet supported in viewers." to "Note: The placeholderCanvas property is not yet supported in viewers." - so as not to give the impression that it works for Image content.
  • We found one contraction: "Don’t use this property for content"

@glenrobson glenrobson added the meta: ready-for-trc Issue is ready for TRC review label Jul 28, 2020
@github-actions github-actions bot temporarily deployed to staging July 28, 2020 13:57 Inactive
@github-actions github-actions bot temporarily deployed to staging July 28, 2020 20:16 Inactive
@github-actions github-actions bot temporarily deployed to staging July 28, 2020 22:07 Inactive
@glenrobson glenrobson marked this pull request as ready for review July 29, 2020 21:32
@github-actions github-actions bot temporarily deployed to staging July 29, 2020 21:35 Inactive
@glenrobson glenrobson linked an issue Jul 29, 2020 that may be closed by this pull request
Poster Image Displayed Before Interaction #13
Closed
@glenrobson glenrobson mentioned this pull request Jul 29, 2020
Open
@github-actions github-actions bot temporarily deployed to staging August 5, 2020 15:00 Inactive
@github-actions github-actions bot temporarily deployed to staging August 5, 2020 15:28 Inactive
@github-actions github-actions bot temporarily deployed to staging August 7, 2020 18:27 Inactive
@glenrobson glenrobson added meta: approved-by-trc Recipe has been approved by the TRC and removed meta: ready-for-trc Issue is ready for TRC review labels Aug 24, 2020
@glenrobson glenrobson merged commit 63ec251 into master Aug 24, 2020
@glenrobson glenrobson deleted the 0013-placeholderCanvas branch August 24, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@triplingual triplingual

Labels
meta: approved-by-trc Recipe has been approved by the TRC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poster Image Displayed Before Interaction
2 participants
@triplingual @glenrobson