Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe 13: Load a Preview Image Before the Main Content #43

Open
glenrobson opened this issue Jul 29, 2020 · 4 comments
Open

Recipe 13: Load a Preview Image Before the Main Content #43

glenrobson opened this issue Jul 29, 2020 · 4 comments
Assignees
Labels
Milestone

Comments

@glenrobson
Copy link
Member

Links

Background and Summary

This recipe introduces placeholderCanvas with a typical use case for when it might be useful. Unfortunately this feature isn't yet implemented in any viewers so only the JSON-LD is linked to in the example.

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down).

Changes to the recipe will only be made after the TRC voting process has concluded.

Note also this recipe includes a broken link to Audio Presentation with Accompanying Image which is a recipe we hope to bring to the next TRC meeting.

@glenrobson glenrobson added this to the August 2020 milestone Jul 29, 2020
@triplingual
Copy link

Apologies for three last-minute changes: conforming the cookbook TOC listing for this recipe to the actual recipe title, fixing the line highlighting that got out of sync at some point, and inserting a note specifying where a placeholderCanvas's Annotation's target should point.

@triplingual
Copy link

Noting for posterity that I voted 👍🏻 on this recipe that I authored and sponsored.

@glenrobson
Copy link
Member Author

Just to note the pull request now has a conflict as I've merged some of the recipes approved in the last TRC. We won't fix the conflicts or make other changes while it is being voted on. Once its been approved/rejected we will fix the conflicts before merging to master.

@glenrobson
Copy link
Member Author

Issue 43 (Recipe 13: Load a Preview Image Before the Main Content)

+1: 18 [awead cjnishioka cubap emulatingkat glenrobson hadro irv jonhartzler joshuago78 jtweed julsraemy markpatton mcwhitaker mejackreed mixterj mposton-folger nfreire triplingual]
0: 0 []
-1: 0 []
Not TRC: 0 []
Ineligible: 1 [dismorfo]

Result: 18 / 18 = 1.00

Super majority is in favor, issue is approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants