Move compatibilities to main mod and conditionally load #1270
Conversation
addons/compat_csla/config.cpp
Outdated
| @@ -11,11 +11,12 @@ class CfgPatches { | |||
| authors[] = {"CSLA Studio"}; | |||
| url = ECSTRING(main,URL); | |||
| VERSION_CONFIG; | |||
| skipWhenMissingDependencies = 1; | |||
There was a problem hiding this comment.
I don't think we even need these
can't think of a case where someone will have the map_compat but not the base acre
There was a problem hiding this comment.
Ah, you got me just before I updated requiredAddons.
There was a problem hiding this comment.
we don't really need the mod in requiredAddons
we could just leave it like before and the compats just always load and it shouldn't hurt anything
There was a problem hiding this comment.
Some compats do more than just add an entry in CfgAcreWorlds, like SOG's radio replacement (don't want to run that function if SOG isn't even loaded) and the newly coming SPE, as well as improved compat for SOG currently in PR.
There was a problem hiding this comment.
my concern is that we have to wait for 2.14 to merge this PR
not sure if we want to wait for that to get SPE compat
we could use a has_include setup to get these merged now
There was a problem hiding this comment.
Nah, we can wait a few weeks. Previous compats have come much later.
|
I think we want to drop the meta.cpps? |
jonpas
changed the title
jonpas
changed the title
When merged this pull request will:
skipWhenMissingDependenciesQPATHTOFfor WRP file.