Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spearhead 1944 (SPE) compatibility #1264

Merged
merged 13 commits into from
Sep 6, 2023
Merged

Add Spearhead 1944 (SPE) compatibility #1264

merged 13 commits into from
Sep 6, 2023

Conversation

Drofseh
Copy link
Contributor

@Drofseh Drofseh commented Jul 25, 2023 •
edited by jonpas
Loading

When merged this pull request will:

To Do:

  • make logo

@jonpas jonpas added this to the 2.12.0 milestone Jul 28, 2023
@jonpas jonpas changed the title SPE - Add Spearhead 1944 Compat Add Spearhead 1944 (SPE) compatibility Jul 28, 2023
jonpas
jonpas requested changes Aug 6, 2023
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you or @Dahlgren create a logo as well? Won't be used for Workshop but news and possibly other places.

We can ignore meta.cpp as all optionals/compatibilities will likely get put in the base mod with skipWhenMissingDependencies.

optionals/sys_spe/script_component.hpp Outdated Show resolved Hide resolved
optionals/sys_spe/config.cpp Outdated Show resolved Hide resolved
optionals/sys_spe/SPE_Tanks.hpp Outdated Show resolved Hide resolved
optionals/sys_spe/CfgVehicles.hpp Outdated Show resolved Hide resolved
@Drofseh
Copy link
Contributor Author

Drofseh commented Aug 7, 2023 •
edited
Loading

I've found some UBC errors that need fixing
fixed

@Drofseh
Copy link
Contributor Author

Drofseh commented Aug 8, 2023 •
edited
Loading

I'll update this to comply with #1270

done

@jonpas
Copy link
Member

jonpas commented Sep 6, 2023

@Drofseh Poke for logo if possible. Can also do release without as Workshop items will be going away, but I kind of want to put them on the wiki since we have a nice collection already.

@Dahlgren
Copy link
Contributor

Dahlgren commented Sep 6, 2023 •
edited
Loading

I'll check if my friend who did the past ones is up for another challenge 🙂

I tried making one myself quickly in Gimp but it won't render the "2" in the logo correctly

@Drofseh
Copy link
Contributor Author

Drofseh commented Sep 6, 2023

@Drofseh Poke for logo if possible. Can also do release without as Workshop items will be going away, but I kind of want to put them on the wiki since we have a nice collection already.

I really don't have any ideas for one and am not a visual artist.

@Dahlgren
Copy link
Contributor

Dahlgren commented Sep 6, 2023 •
edited
Loading

Delivery from our community member JoelBitar

acre2_spe_compat_large-logo_512x512

acre2_spe_compat_large-logo.psd.zip
acre2_spe_compat_large-logo_180x180
acre2_spe_compat_large-logo_512x512

jonpas
jonpas requested changes Sep 6, 2023
View reviewed changes
addons/compat_spe/SPE_Tanks.hpp Outdated Show resolved Hide resolved
addons/compat_spe/SPE_Tanks.hpp Outdated Show resolved Hide resolved
addons/compat_spe/SPE_Tanks.hpp Outdated Show resolved Hide resolved
addons/compat_spe/SPE_Tanks.hpp Outdated Show resolved Hide resolved
addons/compat_spe/SPE_Tanks.hpp Outdated Show resolved Hide resolved
addons/compat_spe/SPE_Tanks.hpp Outdated Show resolved Hide resolved
addons/compat_spe/SPE_Tanks.hpp Outdated Show resolved Hide resolved
addons/compat_spe/SPE_Tanks.hpp Outdated Show resolved Hide resolved
addons/compat_spe/SPE_Tanks.hpp Outdated Show resolved Hide resolved
addons/compat_spe/SPE_Tanks.hpp Outdated Show resolved Hide resolved
@jonpas
Copy link
Member

jonpas commented Sep 6, 2023

Delivery from our community member JoelBitar

Amazing!

@jonpas jonpas merged commit aba8192 into IDI-Systems:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror left review comments

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
compatibility feature request
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

SPE Support
4 participants
@Drofseh @jonpas @Dahlgren @PabstMirror