Unticked the NTotal checkbox when opening the column summaries subdialog #9132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
requested changes
Sep 15, 2024
There was a problem hiding this comment.
@derekagorhom please be careful here.
a) It still seems to be ticked for me. Is it unticked on yours?
b) For safety, please start with the updated master. There have been quite some changes in this dialog, and sub-dialog recently. It may not matter, but I don't want to risk regressing on this dialog, for the sake of this small change.
Here is an example that is fixed in the latest version, but not in yours.
|
@rdstern I updated this branch can you check again |
N-thony
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partly #9123
This PR fixes part (a) of the issue. which is to untick the N total checkbox in the column summaries sub dialog when it open.
currently working on the part b
@N-thony can you have a look and review
thanks