Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A final (?) task in the summary dialog? #9123

Closed
rdstern opened this issue Sep 4, 2024 · 6 comments
Closed

A final (?) task in the summary dialog? #9123

rdstern opened this issue Sep 4, 2024 · 6 comments
Assignees
Milestone

Comments

@rdstern
Copy link
Collaborator

rdstern commented Sep 4, 2024

The Prepare > Data Reshape > Column Summaries is one of the main dialogs in R-Instat. There is still pending work in progress, and then this issue is (I hope) the final task - at this stage to "complete" the dialog. The changes below are for the sub-dialog and this is one that is used by multiple main dialogs.

The pending work is as follows:
a) Tidying the two-variables tab and improving the positions tab. This is pull request #8808 and is awaiting review
b) Implementing the drop unused levels feature. This is pull request #8986 and is (I think) also awaiting review.

There are 2 new changes - one small and one larger.
a) In the initial dialog I always untick the NTotal checkbox when teaching. Please could it be unchecked by default. So just the N not missing and Sum are checked.
b) Please could there be an extra Rename tab. I suggest, for speed, that either @N-thony or @Patowhiz to do the coding? I assume it is essentially the same user control as here?

image

The default width of Name and New Name should be wider, because the default names are sometimes quite long.

@rdstern rdstern added this to the 0.7.23 milestone Sep 4, 2024
@N-thony
Copy link
Collaborator

N-thony commented Sep 11, 2024

There are 2 new changes - one small and one larger. a) In the initial dialog I always untick the NTotal checkbox when teaching. Please could it be unchecked by default. So just the N not missing and Sum are checked.
@derekagorhom can you make this small change?

@N-thony
Copy link
Collaborator

N-thony commented Sep 23, 2024

@rdstern I think @derekagorhom started part b).
@derekagorhom can you update?

@derekagorhom
Copy link
Contributor

@N-thony I have added the Rename tab into the Column Summaries sub-dialog.
the only issue is with the rename column function is not performing the function. i tried using breakpoints too but it does not identify the strNewData, iStartRowIndex, iColIndex in the subdialog
image

@derekagorhom
Copy link
Contributor

@rdstern so What i did with the rename tab in the Column Summaries Sub-dialog was to show Columns of the tables which appeared on the Grid so if the user did the sum and mean of two columns, the table that came after will be able to show on the rename tab. which made them available for renaming. The case here is that the sum and mean operation must create a table first before so that they can be renamed.

@rdstern
Copy link
Collaborator Author

rdstern commented Oct 2, 2024

@derekagorhom I am going to close this issue. I suggest, for now, we omit this possibility and leave it for the presentation of tables, or the rename dialogs

@rdstern
Copy link
Collaborator Author

rdstern commented Oct 2, 2024

So closing

@rdstern rdstern closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants