-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented the drop unused levels checkbox in the Column Summaries dialog #8986
Implemented the drop unused levels checkbox in the Column Summaries dialog #8986
Conversation
@lilyclements I am under the impression you have the change in R, but had "hard-wired it, in your version to test. I hope it could now be included in this pull request, as the condition that the by variables have to be factors is now there. The checkbox should be disabled if they are not. |
@lilyclements can you incorporate your new code in this pull request, so the option can be completed? |
@lilyclements are you ok to add your magiv here. You said you had the solution, but "hardwired". Note it will be needed again later in the Tables dialog. |
@rdstern as you pointed out the changes are in #8794 - thanks! |
updating the br
Adding drop
@rdstern I have added #8794 from @lilyclements into this PR, can you test? |
@lilyclements I am unable to test changes just now (misplaced laptop!). It would be great if this now works. Could you test? |
@lilyclements has agreed to test this. Then, or in parallel, could @Patowhiz check the code and merge. This is an important new feature in the calculation system. (It is also helping an improvement in the climatic dialogs.) |
@N-thony if I understand correctly, then the check unused levels should not be disabled. Let me give an example to check the different options now are possible, In the past there were always 10 rows, because 2 combinations have zero frequencies. (NEW variety is only in 2 of the 4 villages.) Now, with the @lilyclements and your changes, the user can choose - depending on the state of the So if you don't drop the unused levels then I think you should now get the following table. I suggest the 10 rows remain the default, so the Drop Unused Levels checkbox is checked by default. |
@rdstern @lilyclements Drop Unused Levels checkbox is now enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Patowhiz this is a small, but important improvement. I'll explain when we meet. It links to "your" tables too! Hope the code is ok, so it can be merged. |
@Patowhiz I am back testing again and very happy with this new feature. Over to you to check and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing this @lilyclements
Fixes #8730
@rdstern I made the change as requested for the drop unused levels checkbox. @lilyclements can now make the change in the calculation system.