Fixed bug in Column Selection > Partially labelled option #8719
Conversation
There was a problem hiding this comment.
@N-thony it is still giving me columns where there are more labels than values, rather than just those where there are more values than labels. I see the function also on the right and wonder about the last part, where it says (fn=is.containPartialValueLabel))), and_or="|") Is the second part and_or="|" needed? Does it cause any problems?
|
@rdstern have a look, I have added a condition to not select variables with unused labels. |
There was a problem hiding this comment.
@N-thony it now seems to work, so I am approving. Well done.
I would like @Patowhiz to check, but first I wonder if you could see if there is anything you could do with this, and perhaps other options to make it work faster?
In the data I sent, I took the hh data and looked for the partially labelled variables. There are 37. I found it executes the command when you press Return on the sub-dialog, rather than when you press Ok. I am not sure if that is correct.
a) It takes a long time.
b) So I then undid it - cleared and it took ages before getting the dialog - and closed the screen twice during that time.
c) I have a feeling that everything may take a long time once the select is in place? So it only works slowly?
d) I then decided to get another select of all the variables once I had this select. That took a long time to do. But then re-getting that select was very quick
|
@Patowhiz could you check and approve, so this can be merged? |
Fixes #8705
@rdstern check this if it is okay now.