Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select with partial labels should only work in one direction #8705

Closed
rdstern opened this issue Dec 22, 2023 · 1 comment · Fixed by #8719
Closed

Select with partial labels should only work in one direction #8705

rdstern opened this issue Dec 22, 2023 · 1 comment · Fixed by #8719

Comments

@rdstern
Copy link
Collaborator

rdstern commented Dec 22, 2023

@N-thony The partial label featyre you added is designed for situations where there are more (numerical) values than value labels.

The other way round, namely more labels than levels is quite common and is different and should not be included. That's when there are extra factor levels with zero frequency and we handle that differently.
I found this problem with IPUMS data, where they are from one country, but the labels gives all the possible countries. You must be doing a check somewhere for not equal, when ut should be that that there are more values in the data than in the labels.

@N-thony
Copy link
Collaborator

N-thony commented Jan 4, 2024

@N-thony The partial label featyre you added is designed for situations where there are more (numerical) values than value labels.

The other way round, namely more labels than levels is quite common and is different and should not be included. That's when there are extra factor levels with zero frequency and we handle that differently. I found this problem with IPUMS data, where they are from one country, but the labels gives all the possible countries. You must be doing a check somewhere for not equal, when ut should be that that there are more values in the data than in the labels.

@rdstern okay, this will require a bit of demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants