Ensured that factor labels in Plot Options subdialog are correct #8456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
I am approving, because the text seems fine now and I am also happy to have the New rather than Add.
The only problem I could find when testing is - I think - not related to your changes. I tried with the usual survey data and the bar chart dialog. It worked fine. But when I go back in, it reports a developer error.
There are changes being made to the bar chart dialog that I think has introduced this. It should be reported there (as well?) And I'll do that.
It is a message I report with different dialogs reasonably regularly. It does no harm as the dialog then runs fine. But it looks unprofessional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part a of #8451.
In the script window, I also changed the
Addbutton toNew.@rdstern Please can you test?
Note:
The problem was caused by incorrect translations for these 2 labels for several languages in the translations database.
The JSON files and CrowdIn translations are all correct so the problem must have been introduced when I imported the JSON files into the database. I added a regression test so that if this happens again, then I should detect it before merging the new database into master.