Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two recent regressions on the graphics sub-dialog #8451

Closed
rdstern opened this issue Jul 19, 2023 · 2 comments · Fixed by #8474
Closed

Fix two recent regressions on the graphics sub-dialog #8451

rdstern opened this issue Jul 19, 2023 · 2 comments · Fixed by #8474

Comments

@rdstern
Copy link
Collaborator

rdstern commented Jul 19, 2023

@N-thony I suggest these are both easy to fix and could be by anyone? It may be worth a bit of detective work, at the same time, to see how they have arisen, in case there are more that we have yet to uncover.

a) This one seems to do no harm. It has come after Version 0.7.15. It has added 2 lines of exta text, namely 2 digit after the first factor and a long text after the second! Why has this happened and where have they come from?

image

b) The legend, see below:

image

This is a problem. The default used to be None and this has disappeared. This was a problem I didn't notice in 0.7.14 and 15, but I think was ok before.

c) I don't know if this is related to b) In the pair-plot option, see below, I thought the pair-plot options were now enabled. They may be linked to the legend problem above? Maybe they get enabled later when using the dialog? This was pull request #8005 and it mentioned the legend.

image
@lloyddewit
Copy link
Contributor

@rdstern @derekagorhom
For part b) above, the None option was deliberately removed in PR #8316. Was this correct?

image

@derekagorhom
Copy link
Contributor

derekagorhom commented Jul 21, 2023

@lloyddewit
Roger requested that change in issue #8288
see here
image

I think it can be added back again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants