Fixed bug when colour is applied in the dataset from Data View window

[N-thony]

Fixes #7232
@africanmathsinitiative/developers this is ready for review.
@rdstern I have fixed the bug on not setting the colour to the dataset in the Data View, in addition while testing I fixed one small bug I found in the Merge Additional Dialogue. I also realised in version 0.7.2 that with dataset you shared in Skype, the merge dialogue seems to not apply the colour though the second or first dataframe has colour applied but with this version, it seems to keep the colour if applied from one of the dataset in the merged dataset. Please could test on your side and see if I'm right? Thanks.

[rdstern]

@N-thony this now seems to work, so that's a relief.
You may like to pass this on, or continue, for some of the other aspects on this dialogue.
a) The remove colour seems to work fine. But it could enable Ok, even when the receiver is empty. (You don't need to know what property made the colours to clear them.)
b) I thought you might like to remove the property from the metadata, when it is always -1?
c) When there are no colours, perhaps the default could be the Class?
d) I would still like cho9ice on the palettes to be used. This could be a useful very simple dialogue to illustrate the palettes that are usually available. (If needed, this could become another issue, to be done later.)

[N-thony]

@N-thony this now seems to work, so that's a relief. You may like to pass this on, or continue, for some of the other aspects on this dialogue. a) The remove colour seems to work fine. But it could enable Ok, even when the receiver is empty. (You don't need to know what property made the colours to clear them.) b) I thought you might like to remove the property from the metadata, when it is always -1? c) When there are no colours, perhaps the default could be the Class? d) I would still like cho9ice on the palettes to be used. This could be a useful very simple dialogue to illustrate the palettes that are usually available. (If needed, this could become another issue, to be done later.)

@rdstern I resolved items a) to c), please could you check? Thanks.

[ChrisMarsh82]

add _grid.UpdateWorksheetStyle(fillWorkSheet) back to ucrDataView

[ChrisMarsh82]

@N-thony see the latest commit. it looks like there is an issue with reogrid when using entire range. This looks to solve it by changing the style of the top row separately. Please could you check to see if this solution fixes your issue while still allowing users to select a font through the options menu

[N-thony]

@N-thony see the latest commit. it looks like there is an issue with reogrid when using entire range. This looks to solve it by changing the style of the top row separately. Please could you check to see if this solution fixes your issue while still allowing users to select a font through the options menu

@ChrisMarsh82 thank you, I have checked by setting the colour with Colour by Property dialogue and also with the font through the options menu and it seems to work fine.
@rdstern could you re-test?

[rdstern]

@N-thony this seems to work well now - at least initially and visually.
a) The Remove Colour checkbox is available all the time. Should it be deleted if no colour is applied.

b) I removed colour and the result in the metadata seems odd. Visually it is ok. But it has NA for the first entry of metadata and still some numbers. That's perhaps because of the Select I applied.

c) So I deleted the selection and it gave an error.

[N-thony]

@rdstern this seems to be fixed now. Please confirm?

[rdstern]

@N-thony this time I tried it the other way round. So I did a select, before doing the colour. Got this:

Makes me wonder about doing a filter - I'll try. That seems ok.

[N-thony]

@N-thony this time I tried it the other way round. So I did a select, before doing the colour. Got this:

Makes me wonder about doing a filter - I'll try. That seems ok.

@rdstern could you test now?

[N-thony]

@rdstern could you try this now?

[lloyddewit]

@rdstern could you try this now?

@N-thony Before @rdstern tests again, please could you resolve my comment above (else @rdstern will need to test twice)? thanks

[Patowhiz]

I'm now also getting this bug.
When I use 2 data frames with the similar column names, and I try to produce new columns from the dialogs that seem to also be the same across the 2 data frames. this error is thrown.

[lloyddewit]

@rdstern could you try this now?

@N-thony Before @rdstern tests again, please could you resolve my comment above (else @rdstern will need to test twice)? thanks

@N-thony I saw that you resolved my comment, thanks

[lloyddewit]

@N-thony Is this PR now ready for testing or do you still need to take action to address @Patowhiz 's comment above?
Thanks for clarifying

[N-thony]

@N-thony Is this PR now ready for testing or do you still need to take action to address @Patowhiz 's comment above? Thanks for clarifying

@lloyddewit I have discussed with @Patowhiz and found his comment has been fixed.

[lloyddewit]

@rdstern Please can you test?
@ChrisMarsh82 You have an open change request above, which I think will block approval. Please can you approve (I will review/approve separately)?
Thanks

[rdstern]

@N-thony I got build errors?

[N-thony]

@rdstern I'm not getting the build error, let's have a quick call?

[lloyddewit]

@rdstern I'm not getting the build error, let's have a quick call?

@N-thony I also get build errors, clsDataFramePage.vb is incorrect:

[N-thony]

@rdstern I'm not getting the build error, let's have a quick call?

@N-thony I also get build errors, clsDataFramePage.vb is incorrect:

@lloyddewit thanks, I think this is after resolving the conflicts, let me fix it.

[N-thony]

@rdstern I'm not getting the build error, let's have a quick call?

@N-thony I also get build errors, clsDataFramePage.vb is incorrect:

@lloyddewit thanks, I think this is after resolving the conflicts, let me fix it.

@lloyddewit could you try it now?

[lloyddewit]

@N-thony Thank you for the changes. The PR now builds without errors.
@rdstern You should be able to test now

[rdstern]

Good

comment resolved