Complete the Experiments > Define > On-Station dialogue

[rdstern]

This is currently quite neat except it doesn't seem to do anything.
It currently shows the different metadata and you choose 1 property to colour.
But it doesn't colour yet! Instead it adds a Colour property to the metadata and gives it a different number for each different value of the property you choose.

There is an option to Remove colour. This keeps the Colour property, but changes the colour to -1.
You also get -1 if the property you use to colour has NA.

It would be nice to add colours!
Ideally we would colour columns in the data frame and rows in the column metadata.

1. I quite like the idea of separating the production of the colour meta-data from its application. So should we have an Apply Colour Property checkbox? Default is checked. We could go further and have Apply to data frame default checked, and also Apply to Column Metadata, default is unchecked.
   I could picture including this dialogue in teaching about the meta-data and the different windows in R-Instat.
2. Then we need to choose the colours. Could we do this simply by having a selection of palettes, and then choosing a palette?
   The Climatic > Describe > Wind > Windrose dialogue has a neat option for palettes as a sub-dialogue. Could we simply adopt those?
   The code there must already associate colours with the numbers.
3. The class is the obvious property. I suggest we have that as the default. But allow any property to be used (as now)

@dannyparsons this looks like a "low-hanging fruit"? I would like something, so the help can be written. Any quick comments?

I am liking this. I started, feeling this was unimportant, but I think it can help in our teaching role - so making R-Instat easier to use!

[rdstern]

@N-thony has anything happened on this issue? Would you like to allocate it or share it with someone else?

[N-thony]

@N-thony has anything happened on this issue? Would you like to allocate it or share it with someone else?

@rdstern thanks for reminding me. I will share it with one the intern.

[rdstern]

I have just found this!

That is from Version 0.7.2, so before the new grid. It may be that @ChrisMarsh82 needs be involved, but I suspect the code hasn't changed, it's just not doing anything with the new-style grid we now have.

Looking above, since I wrote this message I note that @N-thony has deleted a category in the column metadata, when it isn't needed anymore. So perhaps if the colours are deleted, then so is the property.

So you might separate the tasks, with the first being to get it working mainly as before and then consider adding palettes, etc.

[N-thony]

@rdstern thanks, that is really helpful, I will investigate and try to fix it first, also contact when it will be necessary @ChrisMarsh82

[rdstern]

@derekagorhom I am reopening this issue, because the dialogue is not working well.
It is currently the Experiments > Define > Define On-Station dialogue.
a) I tried it with the Experiment 1 (rice) from the agriTutorial package. Could you also make an issue to add this package.

b) I reordered the variables, in this example, so the Layout are first, then the Treatment ones and then the yield.

Then I used the dialogue:
c) Could you make the colour the default. So it starts with the checkbox ticked.
d) Then I think it is doing the important things ok, namely adding to the column metadata.
e) But it is not remembering the variables in each control when the dialogue is re-opened Please could you fix that.

Thanks

Roger