Climatic Summary #3818
Climatic Summary #3818
Conversation
There was a problem hiding this comment.
@shadrackkibet looks good.
I just noticed something small, can you run a sub which sets the station receiver as the focused receiver when the Annual rdo is checked? Otherwise, the focus may be hidden on a receiver only visible on the Within-Year rdo.
|
Should i also change the receiver focus when on "Within-Year rdo" to be the "Within-Year" Receiver? |
|
I can't quite remember the dialog layout but generally we only need to change the current receiver if we are hiding the current receiver. If we're just changing other things about the dialog, no need to change this. |
|
So we have the former: when we are on the Within-Year rdo, there is a new receiver which pops up. Hence this disappears when you click on the Annual rdo. Therefore, when you click onto the Annual rdo, we need to change the current receiver, otherwise the focus is on a non-visible receiver. |
|
@dannyparsons @lilyclements how can restrict the withinYear receiver to only pick the within-Year variables i.e Month,dekad, etc .Is this possible by setting the receiver's metadata property?. I noticed there this has a bug when you allow the user to select any Element for example "Rain" into this receiver. |
|
I think it's okay as it is. If the user wishes to do it by "Rain", then they can - not that this is in any way advised! However, this way we can allow things like "Day", "doy_366", "Dekad" "Week", etc - variables which are generally automatically numeric. |
|
That's a great point. We should restrict to those "within year types", but since we don't have record this at the moment we can't quite do it. So I think better to allow anything and explain in future we will restrict. |
|
There is no restriction on it at all at the moment, which is what we want for now because then the user can pick factors or numerics |
| Private Sub ReceiverFocus() | ||
| If rdoAnnual.Checked Then | ||
| ucrReceiverStation.SetMeAsReceiver() | ||
| End If |
There was a problem hiding this comment.
This could be modified so that the current receiver only changes if the receiver that's about to be hidden is the current one. i.e. if another receiver is the current then no need to do this when changing radio buttons.
Can you look into this? but I will still merge this version now because it's a small improvement.
@africanmathsinitiative/developers this is ready for review.