Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #216

Merged
merged 19 commits into from
Nov 10, 2019
Merged

Various improvements #216

merged 19 commits into from
Nov 10, 2019

Conversation

yannikschaelte
Copy link
Member

  • Document pickling paradigm in ABCSMC class (see doc/sampler.rst).
  • Always use lazy evaluation in updates.
  • Restructure run function of ABCSMC class.

@codecov-io
Copy link

codecov-io commented Nov 10, 2019

Codecov Report

Merging #216 into develop will decrease coverage by 0.08%.
The diff coverage is 76.19%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #216      +/-   ##
===========================================
- Coverage     82.4%   82.31%   -0.09%     
===========================================
  Files           84       84              
  Lines         4467     4473       +6     
===========================================
+ Hits          3681     3682       +1     
- Misses         786      791       +5
Impacted Files Coverage Δ
pyabc/epsilon/base.py 91.3% <ø> (ø) ⬆️
pyabc/distance/base.py 83.67% <ø> (ø) ⬆️
pyabc/epsilon/epsilon.py 87.83% <100%> (+0.16%) ⬆️
pyabc/epsilon/temperature.py 89.87% <100%> (ø) ⬆️
pyabc/acceptor/acceptor.py 91.81% <100%> (+0.9%) ⬆️
pyabc/sampler/base.py 94.11% <50%> (-3.96%) ⬇️
pyabc/distance/distance.py 80.95% <62.5%> (-0.65%) ⬇️
pyabc/smc.py 94.38% <85.29%> (-0.3%) ⬇️
pyabc/sampler/redis_eps/cli.py 79.85% <0%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2053448...4b47824. Read the comment docs.

@yannikschaelte yannikschaelte merged commit 22e045e into develop Nov 10, 2019
@yannikschaelte yannikschaelte deleted the feature_improve_minors branch November 10, 2019 15:37
@yannikschaelte yannikschaelte mentioned this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants