Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(all rules): Rule help Requirement matches Requirement listing rule #1967

Merged
merged 3 commits into from
Aug 5, 2024
Merged

fixrule(all rules): Rule help Requirement matches Requirement listing rule #1967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9dbd753
6522 Rule help matches Requirement listing rule
philljenkins Aug 1, 2024
a0f5584
Merge branch 'master' into phill-help-mapping
philljenkins Aug 2, 2024
dc920f9
Merge branch 'master' into phill-help-mapping
ErickRenteria Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions accessibility-checker-engine/help-v4/en-US/application_content_accessible.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,11 @@ <h3 id="ruleMessage"></h3>

### What to do

* Verify that the content is decorative;
* **Or**, associate the content with a focusable element using the `aria-labelledby` or `aria-describedby` attribute;
* **Or**, place the content in a focusable element that has role `"document"` or `"article"`;
* **Or**, manage the focus of descendants as described in [Developing a Keyboard Interface](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/) by updating the value of `aria-activedescendant` to reference the element containing the focused content.
* Verify that the content is decorative
* **Or**, associate the content with a focusable element using the `aria-labelledby` or `aria-describedby` attribute
* **Or**, place the content in a focusable element that has role `"document"` or `"article"`
* **Or**, manage the focus of descendants as described in [Developing a Keyboard Interface](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/) by updating the value of `aria-activedescendant` to reference the element containing the focused content
* **And if**, the application provides assistive technology, use platform and other industry standard accessibility services

</script></mark-down>
<!-- End main panel -->
Expand All @@ -65,12 +66,15 @@ <h3 id="ruleMessage"></h3>
</div>
<div class="bx--col-sm-4 bx--col-md-3 bx--col-lg-4 toolSide">
<!-- Start side panel -->
<!-- Match mapping in rule -->
<mark-down><script type="text/plain">

### About this requirement

* [IBM 4.1.2 Name, Role, Value](https://www.ibm.com/able/requirements/requirements/#4_1_2)
* [IBM 1.1.1 Non-text content](https://www.ibm.com/able/requirements/requirements/#1_1_1)
* [IBM 2.1.1 Keyboard](https://www.ibm.com/able/requirements/requirements/#2_1_1)
* [ARIA practices - Developing a Keyboard Interface](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/)
* See if [503.3 Alternative User Interfaces](https://www.ibm.com/able/requirements/requirements/#503_3) applies

### Who does this affect?

Expand Down
9 changes: 6 additions & 3 deletions accessibility-checker-engine/help-v4/en-US/aria_attribute_valid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ <h3 id="ruleMessage"></h3>

### What to do

* Remove ARIA state or property attributes that are not valid for the element role;
* **Or**, change the `role` value to a role that supports the intended behavior of the element, using the ARIA specification as a guide.
* Remove ARIA state or property attributes that are not valid for the element role
* **Or**, change to a role that supports the intended behavior of the element, using the ARIA specification as a guide

In the following example, the element references only valid ARIA attributes for an element with the role of `"tree"`, a global `aria-labelledby` property, and an `aria-expanded` state:

Expand All @@ -72,12 +72,15 @@ <h3 id="ruleMessage"></h3>
</div>
<div class="bx--col-sm-4 bx--col-md-3 bx--col-lg-4 toolSide">
<!-- Start side panel -->
<!-- remove 4.1.2 from reference, but include ARIA spec reference -->
<!-- rule maps to ACT, so add references if missing -->
<mark-down><script type="text/plain">

### About this requirement

* [IBM 4.1.2 Name, Role, Value](https://www.ibm.com/able/requirements/requirements/#4_1_2)
* [ARIA specification - States and Properties](https://www.w3.org/TR/wai-aria-1.2/#introstates)
* [ACT rule - ARIA state or property is permitted](https://www.w3.org/WAI/standards-guidelines/act/rules/5c01ea/)
* [ACT rule - Element marked as decorative is not exposed](https://www.w3.org/WAI/standards-guidelines/act/rules/46ca7f/)

### Who does this affect?

Expand Down
3 changes: 2 additions & 1 deletion accessibility-checker-engine/help-v4/en-US/canvas_content_described.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,9 @@ <h3 id="ruleMessage"></h3>

* [IBM 1.1.1 Non-Text Content](https://www.ibm.com/able/requirements/requirements/#1_1_1)
* [IBM 2.1.1 Keyboard](https://www.ibm.com/able/requirements/requirements/#2_1_1)
* [IBM 2.4.7 Focus Visible](https://www.ibm.com/able/requirements/requirements/#2_4_7)
* [IBM 4.1.2 Name, Role, Value](https://www.ibm.com/able/requirements/requirements/#4_1_2)
* [Design - Visual states]()
* [Canvas accessibility by pauljadam.com](https://pauljadam.com/demos/canvas.html)

### Who does this affect?

Expand Down
8 changes: 5 additions & 3 deletions accessibility-checker-engine/help-v4/en-US/input_label_after.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,15 @@ <h3 id="ruleMessage"></h3>
</div>
<div class="bx--col-sm-4 bx--col-md-3 bx--col-lg-4 toolSide">
<!-- Start side panel -->
<!-- Remove 1.3.1 & 4.1.2 from help add replace with 3.3.2 -->
<mark-down><script type="text/plain">

### About this requirement

* [IBM 1.3.1 Info and Relationships](https://www.ibm.com/able/requirements/requirements/#1_3_1)
* [IBM 4.1.2 Name, Role, Value](https://www.ibm.com/able/requirements/requirements/#4_1_2)
* [H44: Associate text labels with form controls](https://www.w3.org/WAI/WCAG22/Techniques/html/H44)
* [IBM 3.3.2 Info and Relationships](https://www.ibm.com/able/requirements/requirements/#3_3_2)
* [Design - Input labels](https://www.ibm.com/able/toolkit/design/content/#input-labels)
* [Develop - Programmatically associate inputs with labels](https://www.ibm.com/able/toolkit/develop/user-input/#inputs)
* [G162: Positioning labels to maximize predictability of relationships](https://www.w3.org/WAI/WCAG22/Techniques/general/G162)

### Who does this affect?

Expand Down
7 changes: 5 additions & 2 deletions accessibility-checker-engine/help-v4/en-US/input_label_before.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,15 @@ <h3 id="ruleMessage"></h3>
</div>
<div class="bx--col-sm-4 bx--col-md-3 bx--col-lg-4 toolSide">
<!-- Start side panel -->
<!-- Remove 1.3.1 & 4.1.2 from help add replace with 3.3.2 -->
<mark-down><script type="text/plain">

### About this requirement

* [IBM 1.3.1 Info and Relationships](https://www.ibm.com/able/requirements/requirements/#1_3_1)
* [IBM 4.1.2 Name, Role, Value](https://www.ibm.com/able/requirements/requirements/#4_1_2)
* [IBM 3.3.2 Info and Relationships](https://www.ibm.com/able/requirements/requirements/#3_3_2)
* [Design - Input labels](https://www.ibm.com/able/toolkit/design/content/#input-labels)
* [Develop - Programmatically associate inputs with labels](https://www.ibm.com/able/toolkit/develop/user-input/#inputs)
* [G162: Positioning labels to maximize predictability of relationships](https://www.w3.org/WAI/WCAG22/Techniques/general/G162)

### Who does this affect?

Expand Down
2 changes: 2 additions & 0 deletions accessibility-checker-engine/help-v4/en-US/media_audio_transcribed.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,12 @@ <h3 id="ruleMessage"></h3>
### About this requirement

* [IBM 1.2.1 Audio-only and Video-only (Prerecorded)](https://www.ibm.com/able/requirements/requirements/#1_2_1)
* [Design - Video transcripts](https://www.ibm.com/able/toolkit/design/content/#video-transcripts)

### Who does this affect?

* People who are deaf or hard of hearing
* People who are deaf-blind
* People in a situation where they cannot use audio on their devices

</script></mark-down>
Expand Down
3 changes: 3 additions & 0 deletions accessibility-checker-engine/help-v4/en-US/media_track_available.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,14 @@ <h3 id="ruleMessage"></h3>
</div>
<div class="bx--col-sm-4 bx--col-md-3 bx--col-lg-4 toolSide">
<!-- Start side panel -->
<!-- Should be both 1.2.3 and 1.2.5 in Help -->
<mark-down><script type="text/plain">

### About this requirement

* [IBM 1.2.3 Audio Description or Media Alternative (Prerecorded)](https://www.ibm.com/able/requirements/requirements/#1_2_3)]
* [IBM 1.2.5 Audio Description (Prerecorded)](https://www.ibm.com/able/requirements/requirements/#1_2_5)
* [Design - Visual content in videos](https://www.ibm.com/able/toolkit/design/content/#visual-content-in-videos)

### Who does this affect?

Expand Down
3 changes: 2 additions & 1 deletion accessibility-checker-engine/help-v4/en-US/script_onclick_avoid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,13 @@ <h3 id="ruleMessage"></h3>
</div>
<div class="bx--col-sm-4 bx--col-md-3 bx--col-lg-4 toolSide">
<!-- Start side panel -->
<!-- remove 1.3.1, maps to 2.1.1 only -->
<mark-down><script type="text/plain">

### About this requirement

* [IBM 1.3.1 Info and Relationships](https://www.ibm.com/able/requirements/requirements/#1_3_1)
* [IBM 2.1.1 Keyboard](https://www.ibm.com/able/requirements/requirements/#2_1_1)
* [Failure F42: When emulating links](https://www.w3.org/WAI/WCAG22/Techniques/failures/F42)

### Who does this affect?

Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/help-v4/en-US/script_onclick_misuse.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ <h3 id="ruleMessage"></h3>
</div>
<div class="bx--col-sm-4 bx--col-md-3 bx--col-lg-4 toolSide">
<!-- Start side panel -->
<!-- remove 1.3.1, maps to 2.1.1 only -->
<mark-down><script type="text/plain">

### About this requirement

* [IBM 1.3.1 Info and Relationships](https://www.ibm.com/able/requirements/requirements/#1_3_1)
* [IBM 2.1.1 Keyboard](https://www.ibm.com/able/requirements/requirements/#2_1_1)
* [Failure F42: When emulating links](https://www.w3.org/WAI/WCAG22/Techniques/failures/F42)

Expand Down
10 changes: 7 additions & 3 deletions accessibility-checker-engine/help-v4/en-US/style_highcontrast_visible.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ <h3 id="ruleMessage"></h3>

Windows high contrast mode alters the way Web content is displayed by disabling certain CSS features.
Applications that use CSS to include, position, or alter non-decorative content may have issues, such as the disappearance of images or UI elements when Windows high contrast mode is enabled.
Another example is the disappearance of visual focus indicators and visual alterations of UI elements with Windows high contrast mode enabled.
Another example is the disappearance of icons, visual focus indicators, and visual alterations of UI elements with Windows high contrast mode enabled.

<!-- This is where the code snippet is injected -->
<div id="locSnippet"></div>
Expand All @@ -59,7 +59,7 @@ <h3 id="ruleMessage"></h3>
* **And**, confirm that checkboxes, radio buttons and text entry field boundaries are visible with good contrast
* **And**, confirm the visual focus indicator is highly visible
* **And**, confirm that all images that convey information are visible, or a text alternative is displayed
* **And**, confirm that all decorative images are no longer visible
* **And**, confirm that only decorative images are no longer visible

</script></mark-down>
<!-- End main panel -->
Expand All @@ -73,9 +73,13 @@ <h3 id="ruleMessage"></h3>
### About this requirement

* [IBM 1.1.1 Non-text content](https://www.ibm.com/able/requirements/requirements/#1_1_1)
* [IBM 1.3.2 Meaningful sequence](https://www.ibm.com/able/requirements/requirements/#1_3_2)
* [IBM 1.4.11 Non-text contrast](https://www.ibm.com/able/requirements/requirements/#1_4_11)
* [Design - Component contrast](https://www.ibm.com/able/toolkit/design/visual/#components-contrast)
* [G207: Ensure contrast for icons](https://www.w3.org/WAI/WCAG22/Techniques/general/G207)
* [Failure F1: CSS positioning that changes the meaning](https://www.w3.org/WAI/WCAG22/Techniques/failures/F1)
* [Failure F3: CSS images that convey important information](https://www.w3.org/WAI/WCAG22/Techniques/failures/F3)
* [Failure F78: Styling element that removes the visual focus](https://www.w3.org/WAI/WCAG22/Techniques/failures/F78)


### Who does this affect?

Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/application_content_accessible.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export let application_content_accessible: Rule = {
},
rulesets: [{
id: [ "IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_0", "WCAG_2_1", "WCAG_2_2"],
num: "2.1.1", // num: [ "2.4.4", "x.y.z" ] also allowed
num: ["1.1.1", "2.1.1"], //match listing in help
level: eRulePolicy.VIOLATION,
toolkitLevel: eToolkitLevel.LEVEL_ONE
}],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/aria_accessiblename_exists.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export let aria_accessiblename_exists: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["1.3.1"],
"num": ["4.1.2"],
"level": eRulePolicy.RECOMMENDATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
}],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/aria_semantics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export let aria_attribute_valid: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["ARIA"],
"num": ["ARIA"], //removed mapping to 4.1.2 from here and help
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
}],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/canvas_content_described.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export let canvas_content_described: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["1.1.1", "4.1.2"],
"num": ["1.1.1", "2.1.1", "4.1.2"],
"level": eRulePolicy.RECOMMENDATION,
"toolkitLevel": eToolkitLevel.LEVEL_THREE
}],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/caption_track_exists.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export let caption_track_exists: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["1.2.1", "1.2.2", "1.2.4"],
"num": ["1.2.2"],
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
}],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/img_alt_redundant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export let img_alt_redundant: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["1.1.1"],
"num": ["1.1.1", "2.4.4"], //match help references
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_TWO
}],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/input_label_visible.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export let input_label_visible: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["3.3.2"],
"num": ["2.5.3", "3.3.2"], //map to both requirements in help
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
}],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/script_focus_blur_review.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export let script_focus_blur_review: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["2.4.7", "3.2.1"],
"num": ["2.1.1", "2.4.7", "3.2.1"], //match requirements listed in help
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
}],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/script_onclick_avoid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export let script_onclick_avoid: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["1.3.1"],
"num": ["2.1.1"], //help and match mapping to 2.1.1 only
"level": eRulePolicy.RECOMMENDATION,
"toolkitLevel": eToolkitLevel.LEVEL_FOUR
}],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/script_onclick_misuse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export let script_onclick_misuse: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["1.3.1"],
"num": ["2.1.1"], //help and match mapping to 2.1.1 only
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
}],
Expand Down
4 changes: 2 additions & 2 deletions accessibility-checker-engine/src/v4/rules/style_highcontrast_visible.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ export let style_highcontrast_visible: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next"],
"num": ["1.1.1"],
"num": ["1.1.1", "1.3.2", "1.4.11"], //other "style" rules for focus, hover, and color
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
},
{
"id": ["WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["1.1.1"],
"num": ["1.1.1", "1.3.2", "1.4.11"],
"level": eRulePolicy.RECOMMENDATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
}],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/style_viewport_resizable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export let style_viewport_resizable: Rule = {
},
rulesets: [{
id: ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_0", "WCAG_2_1", "WCAG_2_2"],
num: "1.4.4", // num: [ "2.4.4", "x.y.z" ] also allowed
num: ["1.4.4", "1.4.10"], // match help for both
level: eRulePolicy.VIOLATION,
toolkitLevel: eToolkitLevel.LEVEL_THREE
}],
Expand Down
Loading