Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(all rules): Rule help Requirement matches Requirement listing rule #1967

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

philljenkins
Copy link
Contributor

@philljenkins philljenkins commented Aug 1, 2024

Updates the following rules

so that the Requirement(s) listed in the help match the rule listed in the Requirements that will be on the Check rule set page when deployed. In some cases, only the help file was changed to match the mapping/reporting of the rule. In other cases, only the mapping was changed to match the help listing. In some cases, the requirements listed in the help and the requirement mapping/reporting in the rule were both changed to match:

  1. img_alt_redundant
  2. style_highcontrast_visible
  3. canvas_content_described
  4. caption_track_exists
  5. media_track_available
  6. caption_track_exists
  7. script_onclick_avoid
  8. script_onclick_misuse
  9. aria_accessiblename_exists
  10. style_viewport_resizable
  11. application_content_accessible
  12. aria_content_in_landmark
  13. script_focus_blur_review
  14. input_label_after
  15. input_label_before
  16. input_label_visible
  17. canvas_content_described
  18. aria_attribute_valid

This PR is related to the following issue(s):

Testing reference:

  • Confirm list of rules above by comparing the Help files with the Rule listing built in Actions
    • Is rule listed under Requirement?
    • Is Requirement listed in "About this requirement section in each help page?

For example:

Screenshot 2024-08-02 at 7 21 46 AM Screenshot 2024-08-02 at 7 24 04 AM

About this requirement

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins requested a review from shunguoy August 2, 2024 12:04
@ErickRenteria ErickRenteria merged commit 33f454d into master Aug 5, 2024
15 checks passed
@philljenkins philljenkins self-assigned this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants