fix: move validator dependency to correct package within monorepo
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `validator` dependency is only used in the ruleset package but was still living in the `package.json` for the validator package. This was likely an oversight during the re-architecture into a monorepo. This resolves the issue. Signed-off-by: Dustin Popp <[email protected]>
dpopp07
force-pushed
the
dp/missing-deps
branch
from
e0be822 to
4582146
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Dec 14, 2022
## @ibm-cloud/openapi-ruleset [0.45.2](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/[email protected]...@ibm-cloud/[email protected]) (2022-12-14) ### Bug Fixes * move `validator` dependency to correct package within monorepo ([#529](#529)) ([6904445](6904445))
|
🎉 This PR is included in version 0.45.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Dec 14, 2022
## ibm-openapi-validator [0.97.2](https://github.com/IBM/openapi-validator/compare/[email protected]@0.97.2) (2022-12-14) ### Bug Fixes * move `validator` dependency to correct package within monorepo ([#529](#529)) ([6904445](6904445)) ### Dependencies * **@ibm-cloud/openapi-ruleset:** upgraded to 0.45.2
|
🎉 This PR is included in version 0.97.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
validatordependency is only used in the ruleset package but was still living in thepackage.jsonfor the validator package. This was likely an oversight during the re-architecture into a monorepo. This resolves the issue by moving the dependency to the correctpackage.json.Resolves #528