New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator dependency not declared #528

Closed

erezarnon opened this issue Dec 14, 2022 · 3 comments · Fixed by #529

Labels

erezarnon commented Dec 14, 2022

When running lint-openai with yarn pnp, you get the following error

Error: @ibm-cloud/openapi-ruleset tried to access validator, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Looks like openapi-ruleset/src/functions/security-scheme-attributes.js imports validator, but the validator package isn't declared as a dependency of the ruleset package.

The text was updated successfully, but these errors were encountered:

Member

dpopp07 commented Dec 14, 2022

Great catch! Will be resolved in #529

dpopp07 mentioned this issue

fix: move validator dependency to correct package within monorepo #529

Merged

dpopp07 closed this as completed in #529

ibm-devx-sdk commented Dec 14, 2022

🎉 This issue has been resolved in version 0.45.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

ibm-devx-sdk added the released label

ibm-devx-sdk commented Dec 14, 2022

🎉 This issue has been resolved in version 0.97.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

gkweb added a commit to gkweb/orval that referenced this issue


          fix(core): bump ibm-openapi-validator to resolve IBM/openapi-validato…

274c7b1

…r#528

gkweb mentioned this issue

fix(core): bump ibm-openapi-validator to resolve https://github.com/I… orval-labs/orval#783

Merged

3 tasks

anymaniax pushed a commit to orval-labs/orval that referenced this issue


          fix(core): bump ibm-openapi-validator to resolve IBM/openapi-validato…

f69a84d

…r#528 (#783)

renovate bot referenced this issue in Unleash/unleash


          chore(deps): update dependency orval to v6.14.3 (#3612)

cb6230e

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [orval](https://togithub.com/anymaniax/orval) | [`6.11.0` ->
`6.14.3`](https://renovatebot.com/diffs/npm/orval/6.11.0/6.14.3) |
[![age](https://badges.renovateapi.com/packages/npm/orval/6.14.3/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/orval/6.14.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/orval/6.14.3/compatibility-slim/6.11.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/orval/6.14.3/confidence-slim/6.11.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>anymaniax/orval</summary>

###
[`v6.14.3`](https://togithub.com/anymaniax/orval/releases/tag/v6.14.3):
Release 6.14.3

[Compare
Source](https://togithub.com/anymaniax/orval/compare/v6.14.2...v6.14.3)

##### Bug Fixes

- **core:** resolve value avoid infinite loop on multi files refs by
adding a parents relation
([9707881](https://togithub.com/anymaniax/orval/commit/9707881fb79bf4114bece546b8339649856ac9a5))

###
[`v6.14.2`](https://togithub.com/anymaniax/orval/releases/tag/v6.14.2):
Release 6.14.2

[Compare
Source](https://togithub.com/anymaniax/orval/compare/v6.14.1...v6.14.2)

##### Bug Fixes

- **core:** resolve value on readonly avoid infinite loop on multi files
refs
([05c966f](https://togithub.com/anymaniax/orval/commit/05c966fafae34113acc2cab2da541638b71f962c))

###
[`v6.14.1`](https://togithub.com/anymaniax/orval/releases/tag/v6.14.1):
Release 6.14.1

[Compare
Source](https://togithub.com/anymaniax/orval/compare/v6.14.0...v6.14.1)

##### Bug Fixes

- **core:** add non readonly only inside implementation file when needed
([3be6a54](https://togithub.com/anymaniax/orval/commit/3be6a54131f311144e71384c3adc77c4b00c8494))

###
[`v6.14.0`](https://togithub.com/anymaniax/orval/releases/tag/v6.14.0):
Release 6.14.0

[Compare
Source](https://togithub.com/anymaniax/orval/compare/v6.13.1...v6.14.0)

##### Bug Fixes

- correctly handle enums without type properties
([#&#8203;814](https://togithub.com/anymaniax/orval/issues/814))
([daf83a5](https://togithub.com/anymaniax/orval/commit/daf83a5e6bc840c171dc09bdc3f94b7297c94ded))
- **zod:** avoid deplicated consts declaration
([03a058f](https://togithub.com/anymaniax/orval/commit/03a058f3f52f2a3209ea0187badfd41f950c96f3))
- **zod:** change import to handle synthetic import config
([8a37cda](https://togithub.com/anymaniax/orval/commit/8a37cdabd50a4efb9d58d088d4e74389669bcfbe))

##### Features

- **core:** remove readonly properties from request body
([#&#8203;813](https://togithub.com/anymaniax/orval/issues/813))
([f5b1ec9](https://togithub.com/anymaniax/orval/commit/f5b1ec9a6eb9eca48eedf2e5df283fee113123c9))
- **packages:** add option to filter generated endpoints
([#&#8203;810](https://togithub.com/anymaniax/orval/issues/810))
([673bb55](https://togithub.com/anymaniax/orval/commit/673bb55e5a3c85cfc69e7b13f44da50bc9a2da07))
- **query:** generate query and mutation options functions
([#&#8203;821](https://togithub.com/anymaniax/orval/issues/821))
([79e9527](https://togithub.com/anymaniax/orval/commit/79e95277a2c16b32b4459556eb8ac56076bfd7f4))

###
[`v6.13.1`](https://togithub.com/anymaniax/orval/releases/tag/v6.13.1):
Release 6.13.1

[Compare
Source](https://togithub.com/anymaniax/orval/compare/v6.13.0...v6.13.1)

##### Bug Fixes

- **zod:** handling correctly deeper ref by deferencing
([3aa9162](https://togithub.com/anymaniax/orval/commit/3aa91622dc8d29c7ae545543870db1b4c119165c))

###
[`v6.13.0`](https://togithub.com/anymaniax/orval/releases/tag/v6.13.0):
Release 6.13.0

[Compare
Source](https://togithub.com/anymaniax/orval/compare/v6.12.1...v6.13.0)

##### Features

- **clients:** add zod
([#&#8203;785](https://togithub.com/anymaniax/orval/issues/785))
([cebdb2e](https://togithub.com/anymaniax/orval/commit/cebdb2e802407b4d691d1a9c82f4bb3809248529))
- **query-swr:** cache key as const
([b102f54](https://togithub.com/anymaniax/orval/commit/b102f548986de19bb2b8c99f4a0f493298c0923d))

###
[`v6.12.1`](https://togithub.com/anymaniax/orval/releases/tag/v6.12.1):
Release 6.12.1

[Compare
Source](https://togithub.com/anymaniax/orval/compare/v6.12.0...v6.12.1)

##### Bug Fixes

- **core:** bump ibm-openapi-validator to resolve
[https://github.com/IBM/openapi-validator/issues/528](https://togithub.com/IBM/openapi-validator/issues/528)
([#&#8203;783](https://togithub.com/anymaniax/orval/issues/783))
([f69a84d](https://togithub.com/anymaniax/orval/commit/f69a84d02c343160fbb16f15c6ba57a0ddcb64fb))
- **jsdoc:** add jsDoc to query parameters
([#&#8203;741](https://togithub.com/anymaniax/orval/issues/741))
([b384ff4](https://togithub.com/anymaniax/orval/commit/b384ff4925ea22bec8e289c49a92de3cef39255a))
- **query:** options without params remove extra bracket
([5ace2d2](https://togithub.com/anymaniax/orval/commit/5ace2d2dd969d8b3908d66b175e7519b7d5f559c))
- use orval as devDependecy
([#&#8203;692](https://togithub.com/anymaniax/orval/issues/692))
([e480184](https://togithub.com/anymaniax/orval/commit/e480184cd882dcc56cf6984b5bed375282c5221c))
- **writers:** correctly provide all query mutators
([c997240](https://togithub.com/anymaniax/orval/commit/c9972402ea38f59a732239ac9c967362686167f2))

###
[`v6.12.0`](https://togithub.com/anymaniax/orval/releases/tag/v6.12.0):
Release 6.12.0

[Compare
Source](https://togithub.com/anymaniax/orval/compare/v6.11.1...v6.12.0)

##### Bug Fixes

- **core:** request options without second argument correctly stringify
([c2554a7](https://togithub.com/anymaniax/orval/commit/c2554a7bebf33d0ce3d706378360faa928fcd140))
- **options:** normalize correctly query signal
([903e0b5](https://togithub.com/anymaniax/orval/commit/903e0b52b386e97c5489b961c448c3ffb86380ca))

##### Features

- **query:** add new tanstack vue query support and move to query object
([ba7ee98](https://togithub.com/anymaniax/orval/commit/ba7ee988557a63c392c6d9bee50bbd7eddfe3b86))
- **query:** add support of tanstack svelte query
([b26ce92](https://togithub.com/anymaniax/orval/commit/b26ce92e5698040abaeaef8ce43a389b630fc7ee))

###
[`v6.11.1`](https://togithub.com/anymaniax/orval/releases/tag/v6.11.1):
Release 6.11.1

[Compare
Source](https://togithub.com/anymaniax/orval/compare/v6.11.0...v6.11.1)

##### Bug Fixes

- **core:** file loader use default path package to find correctly the
file on all os
([7147b72](https://togithub.com/anymaniax/orval/commit/7147b72527ebc005cc3ec964538b3572e9fe4367))
- **path:** add upath test functions
([a891796](https://togithub.com/anymaniax/orval/commit/a89179683de05bbe334fe4fe6ef9e4d213c52e5c))
- **path:** correctly handle windows path
([6a34606](https://togithub.com/anymaniax/orval/commit/6a34606bd1a8ab8149295fd48143dca2198ddfea))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41OC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTguMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment