Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean out unused css. #4208

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Clean out unused css. #4208

merged 1 commit into from
Nov 14, 2024

Conversation

frjo
Copy link
Contributor

@frjo frjo commented Nov 11, 2024

Fixes #4073

Clearing out some unused css that have accumulated over the years. Also replaced some little used css with tailwind classes. All in all some 400 lines of css got removed.

@frjo frjo added Type: Maintenance Type: Patch Mini change, used in release drafter labels Nov 11, 2024
Copy link
Member

@theskumar theskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant underline and not underlined

@frjo frjo force-pushed the maintenance/unused-css-cleanup-11-24 branch from 374712c to 146c79e Compare November 12, 2024 12:46
@frjo
Copy link
Contributor Author

frjo commented Nov 12, 2024

Yes, definitely. Fixed now.

Copy link
Member

@theskumar theskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very good improvement here. 💯 🚢

@frjo frjo force-pushed the maintenance/unused-css-cleanup-11-24 branch from 146c79e to 9c33b16 Compare November 13, 2024 06:44
@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Nov 13, 2024
@frjo frjo merged commit 2483330 into main Nov 14, 2024
7 checks passed
@frjo frjo removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused CSS related to Submissions
2 participants