Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused CSS related to Submissions #4073

Closed
bickelj opened this issue Jul 30, 2024 · 1 comment · Fixed by #4208
Closed

Remove unused CSS related to Submissions #4073

bickelj opened this issue Jul 30, 2024 · 1 comment · Fixed by #4208
Labels
Type: Bug Bugs! Things that are broken :-/

Comments

@bickelj
Copy link
Contributor

bickelj commented Jul 30, 2024

Describe the bug

Unused or inconsistent style code around Edit, Delete, Withdraw submission links.

To Reproduce

See static_src/sass/components/_link.scss and resulting static_compiled/css/main.css for --edit-submission, --delete-submission, --withdraw-submission, and maybe others. Some of these classes do not appear to be used anymore.

Expected behavior

The styles should be used or deleted.

Priority

  • Very Low priority (annoying, would be nice to not see)

Affected roles

  • Staff
  • Applicants
  • Reviewers
  • Partners
  • Developers
@bickelj bickelj added the Type: Bug Bugs! Things that are broken :-/ label Jul 30, 2024
@frjo
Copy link
Contributor

frjo commented Jul 30, 2024

We have been using tailwind more and more in the last year or so. If you find any scss declaration we missed to remove we welcome PRs to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bugs! Things that are broken :-/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants